Basic implementation of following context-sensitive calls in followNextDFGUntilHit
#1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
requested review from
fwendland,
konradweiss and
KuechA
as code owners
…extDFGUntilHit` I am not sure if this really solves *all* the problems, but at least this tries to use the information that we have in the calling context in/out so that we are properly following dataflows into functions and out of functions using the correct call (stack).
oxisto
force-pushed
the
context-sensitive-follow-dfg
branch
from
7894803 to
053202e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
KuechA
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
I like that we will provide a context sensitive analysis. However, we should take care of few aspects:
- maintainability of the selection of the "next step" for
followXUntilHitis getting increasingly complex with a number of similar code fragments (push on stack, pop from stack, select subset of edges, ...) prevDFGdoes not have this feature- The computational complexity will increase if we cannot disable certain stacks in the long term. We should keep this in mind when running it on larger code bases and allow configuring the precision.
- Some functions already provide an interprocedural analysis and probably miss it (e.g. following the PDG, CDG), the EOG does not feature this at all.
I'm fine with the changes but we should discuss how to design a cleaner interface here in the next weeks.
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt
Outdated
Show resolved
Hide resolved
oxisto
added a commit
that referenced
this pull request
Jan 28, 2025
…extDFGUntilHit` (#1988) * Basic implementation of following context-sensitive calls in `followNextDFGUntilHit` I am not sure if this really solves *all* the problems, but at least this tries to use the information that we have in the calling context in/out so that we are properly following dataflows into functions and out of functions using the correct call (stack). * Added flakey test to demonstrate problem * Using a cloned stack, but somehow still does not work * More robust implementation * Added self * Addressed code review
oxisto
added a commit
that referenced
this pull request
Jan 28, 2025
…extDFGUntilHit` (#1988) * Basic implementation of following context-sensitive calls in `followNextDFGUntilHit` I am not sure if this really solves *all* the problems, but at least this tries to use the information that we have in the calling context in/out so that we are properly following dataflows into functions and out of functions using the correct call (stack). * Added flakey test to demonstrate problem * Using a cloned stack, but somehow still does not work * More robust implementation * Added self * Addressed code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this really solves all the problems, but at least this tries to use the information that we have in the calling context in/out so that we are properly following dataflows into functions and out of functions using the correct call (stack).