Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss interface providing configurable selection of sensitivity when following certain subgraphs #1991

Open
KuechA opened this issue Jan 27, 2025 · 0 comments
Open

Discuss interface providing configurable selection of sensitivity when following certain subgraphs #1991

KuechA opened this issue Jan 27, 2025 · 0 comments
Assignees
@KuechA
Labels
code-quality Issues that do not require semantic changes to the code but rather cleanup, refactoring, commenting DFG discussion Label for issues or future features to be discussed before putting them onto the road-map enhancement New feature or request

Comments

@KuechA
Copy link
Contributor

KuechA commented Jan 27, 2025 •
edited
Loading

[...][W]e should take care of few aspects:

  1. maintainability of the selection of the "next step" for followXUntilHit is getting increasingly complex with a number of similar code fragments (push on stack, pop from stack, select subset of edges, ...)
  2. prevDFG does not have this feature
  3. The computational complexity will increase if we cannot disable certain stacks in the long term. We should keep this in mind when running it on larger code bases and allow configuring the precision.
  4. Some functions already provide an interprocedural analysis and probably miss it (e.g. following the PDG, CDG), the EOG does not feature this at all.

I'm fine with the changes but we should discuss how to design a cleaner interface here in the next weeks.

Originally posted by @KuechA in #1988 (review)
@KuechA KuechA added enhancement New feature or request code-quality Issues that do not require semantic changes to the code but rather cleanup, refactoring, commenting discussion Label for issues or future features to be discussed before putting them onto the road-map labels Jan 27, 2025
@oxisto oxisto mentioned this issue Jan 28, 2025
Merged
@oxisto oxisto added the DFG label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KuechA KuechA

Labels
code-quality Issues that do not require semantic changes to the code but rather cleanup, refactoring, commenting DFG discussion Label for issues or future features to be discussed before putting them onto the road-map enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oxisto @KuechA