-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set environment #7
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,9 @@ inputs: | |
team: | ||
description: 'The team corresponding to the event' | ||
required: true | ||
environment: | ||
description: 'The environment corresponding to the event (use "none" if there is none)' | ||
required: true | ||
id: | ||
description: 'The unique identifier of the event. See documentation (TODO) for choosing an ID' | ||
required: true | ||
|
@@ -39,7 +42,7 @@ runs: | |
steps: | ||
- name: Run command | ||
id: run-command | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].1 | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].2 | ||
with: | ||
command: ${{ inputs.command }} | ||
|
||
|
@@ -58,7 +61,7 @@ runs: | |
|
||
- name: Warn on failure | ||
if: ${{ !cancelled() && steps.get-oidc-creds.outcome == 'failure' }} | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].1 | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].2 | ||
with: | ||
message: 'Failed to get OIDC credentials when reporting DSO Metrics. Please investigate the failure.' | ||
|
||
|
@@ -79,7 +82,7 @@ runs: | |
|
||
- name: Warn on failure | ||
if: ${{ !cancelled() && steps.assume-dso-role.outcome == 'failure' }} | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].1 | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].2 | ||
with: | ||
message: 'Failed to assume DSO metrics cross-account role when reporting DSO Metrics. Please investigate the failure.' | ||
|
||
|
@@ -91,13 +94,14 @@ runs: | |
steps.assume-dso-role.outcome == 'success' && | ||
inputs.event-type == 'test' | ||
continue-on-error: true | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].1 | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].2 | ||
with: | ||
# TODO add coverage | ||
args: > | ||
-app "${{ inputs.app }}" | ||
-id "${{ inputs.id }}" | ||
-team "${{ inputs.team }}" | ||
-environment "${{ inputs.environment }}" | ||
${{ inputs.event-type }} | ||
-start "${{ steps.run-command.outputs.start-time }}" | ||
-end "${{ steps.run-command.outputs.end-time }}" | ||
|
@@ -106,7 +110,7 @@ runs: | |
|
||
- name: Warn on failure | ||
if: ${{ !cancelled() && steps.report-test-metrics.outcome == 'failure' }} | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].1 | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].2 | ||
with: | ||
message: 'Failed to report test event metrics to the DSO Metrics API. Please investigate the failure.' | ||
|
||
|
@@ -118,7 +122,7 @@ runs: | |
steps.assume-dso-role.outcome == 'success' && | ||
inputs.event-type == 'deploy' | ||
continue-on-error: true | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].1 | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].2 | ||
with: | ||
args: > | ||
-app "${{ inputs.app }}" | ||
|
@@ -132,6 +136,6 @@ runs: | |
|
||
- name: Warn on failure | ||
if: ${{ !cancelled() && steps.report-deploy-metrics.outcome == 'failure' }} | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].1 | ||
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected].2 | ||
with: | ||
message: 'Failed to report deploy event metrics to the DSO Metrics API. Please investigate the failure.' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think people often copy-paste these examples, and when
0.2.2
is outdated they will copy-paste that :) That's why I put{ref}
so it wouldn't work when copy-pasted and they would need to think about it someThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was:
*
and we don't want to encourage that (we want the default to be that they will pin to the latest released version at the time they set it up)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, makes sense, as long as we remember to do it :)