Set environment #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-harvey
approved these changes
Jul 1, 2024
| @@ -23,12 +24,13 @@ Here's an example of how to use this action in your workflow: | |||
|
|
|||
| ```yaml | |||
| - name: Run Command And Report DSO Event | |||
| uses: Enterprise-CMCS/mac-fc-report-dso-event@{ref} | |||
| uses: Enterprise-CMCS/mac-fc-report-dso-event@0.2.2 | |||
There was a problem hiding this comment.
I think people often copy-paste these examples, and when 0.2.2 is outdated they will copy-paste that :) That's why I put {ref} so it wouldn't work when copy-pasted and they would need to think about it some
There was a problem hiding this comment.
My thinking was:
- they might just put
*and we don't want to encourage that (we want the default to be that they will pin to the latest released version at the time they set it up) - we already have to make a change updating references (in action.yml) whenever we bump the version number, so changing it in one more place doesn't seem harder to me.
There was a problem hiding this comment.
Sure, makes sense, as long as we remember to do it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.