Pm searchbar improvements

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs

@@ -304,8 +304,11 @@ public string SearchText
             get { return _SearchText; }
             set
             {
-                _SearchText = value;
-                RaisePropertyChanged("SearchText");
+                if(_SearchText!= value)
+                {
+                    _SearchText = value;
+                    RaisePropertyChanged("SearchText");
+                }
             }
         }
 
@@ -458,6 +461,7 @@ public bool InitialResultsLoaded
             get { return _initialResultsLoaded; }
             set
             {
+                if (value == _initialResultsLoaded) return;
                 _initialResultsLoaded = value;
                 RaisePropertyChanged(nameof(InitialResultsLoaded));
             }
@@ -1059,19 +1063,24 @@ public bool TimedOut
             }
         }
 
+        private System.Timers.Timer aTimer;
+
         private void StartTimer()
         {
-            var aTimer = new System.Timers.Timer();
+            if(aTimer == null) 
+                aTimer = new System.Timers.Timer();
+
             aTimer.Elapsed += new ElapsedEventHandler(OnTimedEvent);
             aTimer.Interval = MAX_LOAD_TIME;
             aTimer.AutoReset = false;
             aTimer.Enabled = true;
+            aTimer.Start();
         }
 
         private void OnTimedEvent(object sender, ElapsedEventArgs e)
         {
             var aTimer = (System.Timers.Timer)sender;
-            aTimer.Dispose();
+            aTimer.Stop();
 
             // If we have managed to get all the results
             // Simply dispose of the timer
@@ -1347,6 +1356,7 @@ internal IEnumerable<PackageManagerSearchElementViewModel> GetAllPackages()
                 list.Reverse();
             }
 
+            // TODO - should we be unsubsribing somewhere?
             foreach (var x in list)
                 x.RequestShowFileDialog += OnRequestShowFileDialog;
 
@@ -1566,10 +1576,7 @@ public void DisableSearchTextBox()
         /// </summary>
         internal void Close()
         {
-            TimedOut = false;   // reset the timedout screen 
-            InitialResultsLoaded = false;   // reset the loading screen settings
-            RequestShowFileDialog -= OnRequestShowFileDialog;
-            nonHostFilter.ForEach(f => f.PropertyChanged -= filter_PropertyChanged);
+            SearchAndUpdateResults(String.Empty); // reset the search text property
         }
     }
 }

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

@@ -1486,6 +1486,7 @@ private void DynamoViewModelRequestRequestPackageManagerPublish(PublishPackageVi
         private PackageManagerSearchView _searchPkgsView;
         private PackageManagerSearchViewModel _pkgSearchVM;
         private PackageManagerViewModel _pkgVM;
+        private bool _initialSearch = false;
 
         private void DynamoViewModelRequestShowPackageManagerSearch(object s, EventArgs e)
         {
@@ -2274,9 +2275,14 @@ private void DynamoViewModelRequestShowPackageManager(object s, EventArgs e)
             {
                 packageManagerWindow.Navigate((e as OpenPackageManagerEventArgs).Tab);
             }
-            _pkgSearchVM.RefreshAndSearchAsync();
+            if (!_initialSearch)
+            {
+                _initialSearch = true;
+                _pkgSearchVM.RefreshAndSearchAsync();
+            }
         }
 
+
         internal void EnableEnvironment(bool isEnabled)
         {
             this.mainGrid.IsEnabled = isEnabled;

src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerSearchControl.xaml

@@ -335,7 +335,8 @@
                     <!--  Search Bar  -->
                     <local:SearchBoxControl x:Name="SearchBox"
                                             DockPanel.Dock="Left"
-                                            Margin="0 5 0 0" />
+                                            Margin="0 5 0 0"
+                                            IsEnabled="{Binding Path=InitialResultsLoaded, UpdateSourceTrigger=PropertyChanged}" />
 
                 </DockPanel>
             </Border>
@@ -387,18 +388,16 @@
                         Visibility="{Binding IsAnyFilterOn, Converter={StaticResource BoolToVisibilityCollapsedConverter}, UpdateSourceTrigger=PropertyChanged}" />
             </DockPanel>
 
-
-            <local:PackageManagerPackageAnimationControl x:Name="loadingScreen"
+            <local:PackageManagerPackageAnimationControl x:Name="loadingAnimationSearchControlScreen"
                                                          Grid.Row="2"
-                                                         Visibility="{Binding Path=InitialResultsLoaded, UpdateSourceTrigger=PropertyChanged,
-                                                                Converter={StaticResource InverseBooleanToVisibilityCollapsedConverter}}" />
+                                                         Visibility="Visible" />
 
             <local:PackageManagerPackagesControl x:Name="packageManagerSearchPackages"
                                                  Grid.Row="2"
                                                  SearchItems="{Binding Path=SearchResults}"
                                                  Visibility="{Binding Path=InitialResultsLoaded, UpdateSourceTrigger=PropertyChanged,
                                                                       Converter={StaticResource BoolToVisibilityCollapsedConverter}}" />
-
+            
 
         </Grid>
 

src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerSearchControl.xaml.cs

@@ -2,6 +2,7 @@
 using System.Windows.Controls;
 using System.Windows.Controls.Primitives;
 using System.Windows.Data;
+using Dynamo.Controls;
 using Dynamo.PackageManager.ViewModels;
 
 namespace Dynamo.PackageManager.UI
@@ -23,6 +24,18 @@ public PackageManagerSearchControl()
         private void InitializeContext(object sender, RoutedEventArgs e)
         {
             PkgSearchVM = this.DataContext as PackageManagerSearchViewModel;
+
+            if (PkgSearchVM != null)
+            {
+                // Create the binding once the DataContext is available
+                var binding = new Binding("InitialResultsLoaded")
+                {
+                    Source = PkgSearchVM,
+                    Converter = new InverseBooleanToVisibilityCollapsedConverter()
+                };
+
+                this.loadingAnimationSearchControlScreen.SetBinding(UIElement.VisibilityProperty, binding);
+            }
         }
 
 

src/DynamoCoreWpf/Views/PackageManager/Controls/SearchBoxControl.xaml

@@ -116,8 +116,7 @@
                             HorizontalAlignment="Stretch"
                             IsEnabled="{Binding RelativeSource={RelativeSource AncestorType=UserControl}, Path=IsEnabled}"
                             TextChanged="SearchTextBox_OnTextChanged"
-                            IsKeyboardFocusWithinChanged="SearchTextBox_OnKeyboardFocusWithinChanged"
-                            Text="{Binding SearchText, UpdateSourceTrigger=PropertyChanged}"></TextBox>
+                            IsKeyboardFocusWithinChanged="SearchTextBox_OnKeyboardFocusWithinChanged"></TextBox>
 
                         <!-- Clear Search -->
 

src/DynamoCoreWpf/Views/PackageManager/Controls/SearchBoxControl.xaml.cs

@@ -1,5 +1,3 @@
-using Dynamo.PackageManager;
-using HelixToolkit.Wpf.SharpDX;
 using System;
 using System.Globalization;
 using System.Windows;
@@ -16,28 +14,28 @@ namespace Dynamo.PackageManager.UI
     public partial class SearchBoxControl : UserControl
     {
         private DispatcherTimer delayTimer;
+        private string userSearchInput = ""; // Store user's input separately
+        private static int delayTime = 100;  // set delay for event 100ms
 
-        // set delay for event 500ms
-        private static int delayTime = 500;
         /// <summary>
         /// Constructor
         /// </summary>
         public SearchBoxControl()
         {
             InitializeComponent();
+
+            delayTimer = new DispatcherTimer();
+            delayTimer.Interval = TimeSpan.FromMilliseconds(delayTime);
+            delayTimer.Tick += DelayTimer_Tick;
         }
-        private static DispatcherTimer Debounce(DispatcherTimer dispatcher, TimeSpan interval, Action action)
+
+        private void DelayTimer_Tick(object sender, EventArgs e)
         {
-            dispatcher?.Stop();
-            dispatcher = null;
-            dispatcher = new DispatcherTimer(interval,  DispatcherPriority.ApplicationIdle, (s, e) =>
-            {
-                dispatcher?.Stop();
-                action.Invoke();
-            }, Dispatcher.CurrentDispatcher);
-            dispatcher?.Start();
-
-            return dispatcher;
+            delayTimer.Stop();
+            var textBox = this.SearchTextBox;
+            if (textBox == null) return;
+            (this.DataContext as PackageManagerSearchViewModel)?.SearchAndUpdateResults(userSearchInput);
+            textBox.Focus();
         }
 
         /// <summary>
@@ -48,15 +46,16 @@ private static DispatcherTimer Debounce(DispatcherTimer dispatcher, TimeSpan int
         /// <exception cref="NotImplementedException"></exception>
         private void SearchTextBox_OnTextChanged(object sender, TextChangedEventArgs e)
         {
+            var textBox = sender as TextBox;
+            if (textBox == null) return;
 
-            Debounce(delayTimer, TimeSpan.FromMilliseconds(delayTime), () =>
-            {
-                var textBox = sender as TextBox;
-                if (textBox == null) return;
-                (this.DataContext as PackageManagerSearchViewModel)?.SearchAndUpdateResults(textBox.Text);
-                textBox.Focus();
-            });
+            userSearchInput = textBox.Text;
+
+            // When text changes, restart the timer
+            delayTimer.Stop();
+            delayTimer.Start();
         }
+
         private void OnSearchClearButtonClicked(object sender, System.Windows.Input.MouseButtonEventArgs e)
         {
             this.SearchTextBox.Clear();
@@ -106,7 +105,7 @@ public object Convert(object[] values, Type targetType, object parameter, Cultur
                 else
                 {
                     if (value != null && string.IsNullOrWhiteSpace(value.ToString()))
-                    {
+                    {   
                         textVisible = true; // If the textbox has no text, we can show the Control..
                     }
                     else