Pm searchbar improvements

[dnenov]

Purpose

PR addressing outstanding issues with the Search of the Package Manager.

• search should no-longer be able during loading screen
• now only performs RefreshAndSearchAsync() once when loading the ViewModel for the first time. This makes subsequent views loads instantaneous
• removed double binding through test_propertyChanged event and direct binding to property; now only triggers the text_propertyChanged
• added value difference check for the SearchText property to stop the possibility of reapplying the same text over and over
• simplified the DispatcherTimer code
• now waits for 100ms after each keystroke before sending a search query
• this may decrease the 'live' feel of the search, but will prevent starting multiple searches in quick succession

This PR cherry-picks and updates on some of the issues in #14553. The old PR will be split into separate PRs for clarity.

Loading search results

Removing RequestShowFileDialog -= OnRequestShowFileDialog;

• this event handler is null and does nothing.
• TODO: However, we are subscribing all searchelementresults without usubscribing. Not sure if that's an issue. https://github.com/DynamoDS/Dynamo/compare/master...dnenov:Dynamo:pm-searchbar-improvements?expand=1#diff-bb521c95d6777ba5ae6d31b92bdd9cf63d44eae8b06941efac80648554ecc287L1350

Removing nonHostFilter.ForEach(f => f.PropertyChanged -= filter_PropertyChanged);

The nonHostFilter are only initialized once and are part of the ViewModel. Since we are not distroying the ViewModel manually, we should not be removing these handlers when the View closes, we want them to remain.

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Release Notes

• disables the search bar functionality while the results are being loaded
• removed the double-binding through textchanged AND property binding
• simplified code for timed trigger of search via the DispatcherTimer
• added value difference check to stop reapplying the same one over and over
• removed unnecessary un-subscriptions

Reviewers

@mjkkirschner
@reddyashish

FYIs

@Amoursol

[QilongTang]

Is this still unsubscribed somewhere?

[dnenov]

Actually, no. This line never made sense in a way, because the RequestShowFileDialog is null here.

We are subscribing each individual PackageManagerSearchElementViewModel to OnRequestShowFileDialog here

Dynamo/src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs

Line 1363 in c64fe07

foreach (var x in list)

. Speaking with @reddyashish these should automatically unsubscribe when the collection is destroyed.

[reddyashish]

@QilongTang OnRequestShowFileDialog is subscribed to the elements in the packages list which should be disposed when the window is closed. So want to confirm if we still need to unsubscribe it.

[QilongTang]

LGTM with a few questions

[reddyashish]

@QilongTang OnRequestShowFileDialog is subscribed to the elements in the packages list which should be disposed when the window is closed. So want to confirm if we still need to unsubscribe it.