[TradingMode] init health check #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
approved these changes
Dec 8, 2023
| return created_orders | ||
|
|
||
| async def single_exchange_process_optimize_initial_portfolio( | ||
| self, sellable_assets, target_asset: str, tickers: dict | ||
| ) -> list: | ||
| raise NotImplementedError("single_exchange_process_optimize_initial_portfolio is not implemented") | ||
|
|
||
| @contextlib.asynccontextmanager | ||
| async def _single_exchange_operation(self, operation_name): |
Herklos
reviewed
Dec 8, 2023
For DCA, we can by setting the theshold to 100, do you think we need more than this ? agree for the grid part, i'll add it |
I'm not sure we should use an "indirect" value like a 100% threshold to disable healthcheck, it's not easy to understand in my opinion. We may have something like a checkbox (or equivalent) to allow users to enable / disable health check. |
GuillaumeDSM
force-pushed
the
health_check
branch
from
fbcbdc5 to
751630b
Compare
Herklos
approved these changes
Dec 9, 2023
| @@ -354,6 +354,8 @@ async def trading_mode_trigger(self): | |||
| except asyncio.TimeoutError as e: | |||
| raise errors.InitializingError() from e | |||
| self.logger.debug("Order initialized") | |||
| if self.trading_mode.should_trigger_health_check() and not skip_health_check: | |||
GuillaumeDSM
force-pushed
the
health_check
branch
from
751630b to
f9d71cd
Compare
Herklos
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Drakkar-Software/OctoBot-Commons#412