[DCA][Staggered] init health check #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
reviewed
Dec 8, 2023
| await producer.trigger_staggered_orders_creation() | ||
| return created_orders | ||
|
|
||
| async def _should_rebalance_orders(self): |
| @@ -42,6 +42,7 @@ class GridTradingMode(staggered_orders_trading.StaggeredOrdersTradingMode): | |||
| USER_COMMAND_PAUSE_ORDER_MIRRORING = "pause orders mirroring" | |||
| USER_COMMAND_TRADING_PAIR = "trading pair" | |||
| USER_COMMAND_PAUSE_TIME = "pause length in seconds" | |||
| SUPPORTS_HEALTH_CHECK = False # WIP # set True when self.health_check is implemented | |||
There was a problem hiding this comment.
Why isn't it the same implementation as staggered?
There was a problem hiding this comment.
staggered have min and max prices boundaries, it makes orders "grid" translation much more complicated
Herklos
reviewed
Dec 9, 2023
Comment on lines
+719
to
+724
| title="Health check: when enabled, OctoBot will automatically sell traded assets that are not associated " | ||
| "to a sell order and that represent at least the 'Health check threshold' part of the " | ||
| "portfolio. Health check can be useful to avoid inactive funds, for example if a buy order got " | ||
| "filled but no sell order was created. Requires a common quote market for each traded pair. " | ||
| "Warning: will sell any asset associated to a trading pair that is not covered by a sell order, " | ||
| "even if not bought by OctoBot or this trading mode.", |
Comment on lines
+772
to
+781
| if ( | ||
| self.exchange_manager.is_backtesting | ||
| or common_quote is None | ||
| or not (self.use_take_profit_exit_orders or self.use_stop_loss) | ||
| ): | ||
| # skipped when: | ||
| # - backtesting | ||
| # - common_quote is unset | ||
| # - not using take profit or stop losses, health check should not be used | ||
| return [] |
There was a problem hiding this comment.
Shouldn't we override should_trigger_health_check?
There was a problem hiding this comment.
should_trigger_health_check renamed in Drakkar-Software/OctoBot-Trading#1006
| assert sell_order.origin_quantity == eth_holdings | ||
| assert portfolio["ETH"].total == trading_constants.ZERO | ||
| after_eth_usdt_portfolio = portfolio["USDT"].total | ||
| assert after_eth_usdt_portfolio > after_btc_usdt_portfolio |
Herklos
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Drakkar-Software/OctoBot#2476