32 implement ultrasound ranging 01bsp us ranging #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he echo pulse duration in the callback function
…he 01bsp_us_ranging.c
…ulse is set inside hc_sr04.c
…d. This project calls the US driver, initializes US and starts the ranging implemented using PPI. The value of the ECHO pin from the US sensor is passed to a callback us_callback in the us_reading parameter.
aabadie
reviewed
Jun 17, 2022
There was a problem hiding this comment.
This is a first round of reviews with some general comments on the bsp function names (why just us and not hc_sr04.h). I also tried to chase all empty lines that can be removed :).
I'll do another pass of review later. It would be nice to explain the general idea behind the us ranging (in a README or doxygen comment).
…he echo pulse duration in the callback function
…he 01bsp_us_ranging.c
…ulse is set inside hc_sr04.c
…d. This project calls the US driver, initializes US and starts the ranging implemented using PPI. The value of the ECHO pin from the US sensor is passed to a callback us_callback in the us_reading parameter.
…tps://github.com/DotBots/DotBot-firmware-fresh into 32-implement-ultrasound-ranging-01bsp_us_ranging
…_us_ranging.c file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the HC-SR04 ultrasound sensor driver.
The project initializes US and starts the ranging implemented using PPI in the driver. The value of the ECHO pin from the US sensor is passed to a callback in the main project file.
Solves #32