Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-768: Modify the values saved in database for Simple Sample Uploads #686

Merged

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-768, LIMS-650

Summary:

I15-1 have asked for the BLSample.name and Crystal.name fields to be changed for Simple Sample uploads

Changes:

  • Use {acronym}-sample as Crystal.name
  • Use {acronym} as BLSample.name

To test:

  • Go to a 'Phase' eg /phases/pid/580719
  • Click 'New Simple Sample'
  • Fill Acronym as something memorable eg 'foo', and Packing Fraction as 0
  • Verify new sample is created with name 'foo-sample'
  • Verify new instance of sample is created with name 'foo'

@ndg63276 ndg63276 requested a review from gfrn November 17, 2023 09:55
@ndg63276 ndg63276 merged commit ff3e520 into prerelease Nov 17, 2023
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-768/new-names-for-simple-samples branch November 17, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants