Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1192: Fix capillary names #715

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1192

Summary:

A recent change (#686) improved the names of samples, but also affected the names of automatically created capillaries. This then broke things further down the chain.

Changes:

  • Put the crystal name back to how it was for capillaries
  • Use the passed in crystal name for the sample name
  • Change the crystal name passed in for non-capillary crystals

To test:

  • Go to cm37261, then go to Phases, pick one. Click "+ New Simple Sample", fill in the form with a memorable acronym, and use one of the Borosilicate capillaries and submit. Then go to Samples, 2 should have been created. One named acronym-sample, and one ending in _CP for the capillary.
  • Repeat above but with a new acronym and using the _CP sample as your capillary. Only one new sample should be created, but if you drill down to the instance, it will be in a sample group with the _CP sample.

@gfrn gfrn self-requested a review January 23, 2024 15:48
@NKatti2011 NKatti2011 merged commit bd9eb2a into prerelease Jan 24, 2024
2 checks passed
NKatti2011 pushed a commit that referenced this pull request Jan 24, 2024
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
@ndg63276 ndg63276 deleted the fix/LIMS-1192/revert-renaming-of-capillaries branch June 24, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants