Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add span events on graphql error spans #12224

Merged
merged 11 commits into from
Feb 12, 2025

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Feb 4, 2025

Add span events on graphql error spans according to RFC

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Feb 4, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/graphql-add-span-events-errors-a0fb733673ff1f58.yaml  @DataDog/apm-python
tests/snapshots/tests.contrib.graphql.test_graphql.test_graphql_fail.json  @DataDog/apm-python
ddtrace/_trace/span.py                                                  @DataDog/apm-sdk-api-python
ddtrace/contrib/internal/graphql/patch.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/graphene/test_graphene.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/graphql/test_graphql.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.graphene.test_graphene.test_schema_failing_execute.json  @DataDog/apm-python
tests/snapshots/tests.contrib.graphql.test_graphql.test_graphql_error.json  @DataDog/apm-python

@quinna-h quinna-h marked this pull request as ready for review February 4, 2025 21:50
@quinna-h quinna-h requested review from a team as code owners February 4, 2025 21:50
@christophe-papazian christophe-papazian removed their request for review February 5, 2025 08:39
@quinna-h quinna-h requested a review from a team as a code owner February 5, 2025 19:10
ddtrace/_trace/span.py Outdated Show resolved Hide resolved
ddtrace/_trace/span.py Outdated Show resolved Hide resolved
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 5, 2025

Datadog Report

Branch report: quinna.halim/graphql-spans-add-events-on-errors
Commit report: a5c5803
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 28.2s Total duration (25m 44.49s time saved)

ddtrace/_trace/span.py Outdated Show resolved Hide resolved
ddtrace/_trace/span.py Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2025

Benchmarks

Benchmark execution time: 2025-02-12 20:44:04

Comparing candidate commit a5c5803 in PR branch quinna.halim/graphql-spans-add-events-on-errors with baseline commit 0fcafa2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

ddtrace/_trace/span.py Outdated Show resolved Hide resolved
ddtrace/_trace/span.py Outdated Show resolved Hide resolved
ddtrace/_trace/span.py Outdated Show resolved Hide resolved
ddtrace/_trace/span.py Outdated Show resolved Hide resolved
ddtrace/contrib/internal/graphql/patch.py Show resolved Hide resolved
Copy link
Contributor

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some non blocking suggestion, :shipit:

@erikayasuda erikayasuda changed the base branch from 3.x-staging to main February 6, 2025 19:09
@erikayasuda erikayasuda requested a review from a team as a code owner February 6, 2025 20:43
@erikayasuda erikayasuda requested review from a team as code owners February 6, 2025 20:43
@emmettbutler emmettbutler force-pushed the quinna.halim/graphql-spans-add-events-on-errors branch from 0879a13 to 2435838 Compare February 10, 2025 18:11
@emmettbutler emmettbutler changed the title feat: add span events on graphql error spans on 3.x feat: add span events on graphql error spans Feb 10, 2025
Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a possible duplicate of #12181

@quinna-h quinna-h force-pushed the quinna.halim/graphql-spans-add-events-on-errors branch from d8f3aaf to a5c5803 Compare February 12, 2025 20:02
@quinna-h quinna-h enabled auto-merge (squash) February 12, 2025 21:24
@quinna-h quinna-h merged commit 5e12e0b into main Feb 12, 2025
690 checks passed
@quinna-h quinna-h deleted the quinna.halim/graphql-spans-add-events-on-errors branch February 12, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants