-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add span events on graphql error spans #12224
feat: add span events on graphql error spans #12224
Conversation
|
tests/snapshots/tests.contrib.graphene.test_graphene.test_schema_failing_execute.json
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 28.2s Total duration (25m 44.49s time saved) |
releasenotes/notes/graphql-add-span-events-errors-a0fb733673ff1f58.yaml
Outdated
Show resolved
Hide resolved
BenchmarksBenchmark execution time: 2025-02-12 20:44:04 Comparing candidate commit a5c5803 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some non blocking suggestion,
0879a13
to
2435838
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a possible duplicate of #12181
d8f3aaf
to
a5c5803
Compare
Add span events on graphql error spans according to RFC
Checklist
Reviewer Checklist