Skip to content

Commit

Permalink
chore(ci): migrate Appsec fastapi tests (#12196)
Browse files Browse the repository at this point in the history
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Laplie Anderson <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
  • Loading branch information
3 people authored Feb 4, 2025
1 parent eff3155 commit 2ccaaef
Show file tree
Hide file tree
Showing 6 changed files with 87 additions and 1 deletion.
39 changes: 39 additions & 0 deletions hatch.toml
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,45 @@ python = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
flask = ["~=3.0"]


[envs.appsec_integrations_fastapi]
template = "appsec_integrations_fastapi"
dependencies = [
"pytest",
"pytest-cov",
"requests",
"hypothesis",
"jinja2",
"httpx<0.28.0",
"anyio{matrix:anyio:}",
"fastapi{matrix:fastapi}"
]

[envs.appsec_integrations_fastapi.env-vars]
CMAKE_BUILD_PARALLEL_LEVEL = "12"

[envs.appsec_integrations_fastapi.scripts]
test = [
"uname -a",
"pip freeze",
"DD_TRACE_AGENT_URL=\"http://testagent:9126\" DD_CIVISIBILITY_ITR_ENABLED=0 DD_IAST_REQUEST_SAMPLING=100 DD_IAST_DEDUPLICATION_ENABLED=false python -m pytest -vvv {args:tests/appsec/integrations/fastapi_tests/}",
]


# if you add or remove a version here, please also update the parallelism parameter
# in .circleci/config.templ.yml
[[envs.appsec_integrations_fastapi.matrix]]
python = ["3.8", "3.10", "3.13"]
fastapi = ["==0.86.0"]
anyio = ["==3.7.1"]

[[envs.appsec_integrations_fastapi.matrix]]
python = ["3.8", "3.10", "3.13"]
fastapi = ["==0.94.1"]

[[envs.appsec_integrations_fastapi.matrix]]
python = ["3.8", "3.10", "3.13"]
fastapi = ["~=0.114.2"]


## ASM FastAPI

Expand Down
Empty file.
6 changes: 6 additions & 0 deletions tests/appsec/integrations/fastapi_tests/app.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
from fastapi import FastAPI


def get_app():
app = FastAPI()
return app
41 changes: 41 additions & 0 deletions tests/appsec/integrations/fastapi_tests/conftest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
from fastapi.testclient import TestClient
import pytest

import ddtrace
from ddtrace.contrib.internal.fastapi.patch import patch as fastapi_patch
from ddtrace.contrib.internal.fastapi.patch import unpatch as fastapi_unpatch
from tests.utils import DummyTracer
from tests.utils import TracerSpanContainer

from . import app


@pytest.fixture
def tracer():
original_tracer = ddtrace.tracer
tracer = DummyTracer()

ddtrace.tracer = tracer
fastapi_patch()
yield tracer
ddtrace.tracer = original_tracer
fastapi_unpatch()


@pytest.fixture
def test_spans(tracer):
container = TracerSpanContainer(tracer)
yield container
container.reset()


@pytest.fixture
def fastapi_application(tracer):
application = app.get_app()
yield application


@pytest.fixture
def client(tracer, fastapi_application):
with TestClient(fastapi_application) as test_client:
yield test_client
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
from tests.utils import override_global_config


TEST_FILE_PATH = "tests/contrib/fastapi/test_fastapi_appsec_iast.py"
TEST_FILE_PATH = "tests/appsec/integrations/fastapi_tests/test_fastapi_appsec_iast.py"

fastapi_version = tuple([int(v) for v in _fastapi_version.split(".")])

Expand Down

0 comments on commit 2ccaaef

Please sign in to comment.