Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add valkey instrumentation support #12003

Closed
wants to merge 8 commits into from

Conversation

AhmadMasry
Copy link

@AhmadMasry AhmadMasry commented Jan 18, 2025

The Valkey instrumentation is based on the current implementation of the Redis instrumentation, but keeping into consideration that the two projects may deviate and lose compatibility, the Valkey instrumentation is created as a separated module.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@AhmadMasry AhmadMasry marked this pull request as ready for review January 18, 2025 09:46
@AhmadMasry AhmadMasry requested review from a team as code owners January 18, 2025 09:46
ddtrace/contrib/valkey/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ZStriker19 ZStriker19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution!

@ZStriker19 ZStriker19 changed the title Add Valkey instrumentation support feat: Add Valkey instrumentation support Jan 22, 2025
@ZStriker19 ZStriker19 changed the title feat: Add Valkey instrumentation support feat: add valkey instrumentation support Jan 22, 2025
@ZStriker19
Copy link
Contributor

We'll need to move things around a bit after this is merged to make more stuff internal, but this looks good. Will try to get it merged.

@ZStriker19 ZStriker19 enabled auto-merge (squash) January 23, 2025 17:07
ddtrace/contrib/valkey/__init__.py Outdated Show resolved Hide resolved
ddtrace/contrib/valkey/asyncio_patch.py Outdated Show resolved Hide resolved
ddtrace/contrib/valkey/patch.py Outdated Show resolved Hide resolved
ddtrace/contrib/valkey_utils.py Outdated Show resolved Hide resolved
@ZStriker19
Copy link
Contributor

Moving to here so tests will run properly: #12060
Will be sure to make sure it's obvious this is your work @AhmadMasry !

@ZStriker19 ZStriker19 closed this Jan 23, 2025
auto-merge was automatically disabled January 23, 2025 21:51

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants