Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): update security rules to 1.13.2 #11227

Merged

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Oct 30, 2024

Update security rules to 1.13.2

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring backport 2.16 labels Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

CODEOWNERS have been resolved as:

ddtrace/appsec/rules.json                                               @DataDog/asm-python
tests/appsec/integrations/pygoat_tests/test_pygoat.py                   @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_body_no_collection_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_cookies_no_collection_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_span_tags_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.contrib.django.test_django_appsec_snapshots.test_appsec_enabled.json  @DataDog/asm-python
tests/snapshots/tests.contrib.django.test_django_appsec_snapshots.test_appsec_enabled_attack.json  @DataDog/asm-python

@christophe-papazian christophe-papazian changed the title chore(asm) update security rules to 1.13.2 chore(asm): update security rules to 1.13.2 Oct 30, 2024
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: christophe-papazian/update_security_rules_1.13.2
Commit report: f2efe33
Test service: dd-trace-py

✅ 0 Failed, 1286 Passed, 0 Skipped, 32m 41.85s Total duration (7m 38.57s time saved)

@christophe-papazian christophe-papazian marked this pull request as ready for review October 30, 2024 14:45
@christophe-papazian christophe-papazian requested a review from a team as a code owner October 30, 2024 14:45
@christophe-papazian christophe-papazian enabled auto-merge (squash) October 30, 2024 14:46
@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024

Benchmarks

Benchmark execution time: 2024-10-30 18:39:57

Comparing candidate commit 0e3bde4 in PR branch christophe-papazian/update_security_rules_1.13.2 with baseline commit 2378740 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

auto-merge was automatically disabled October 30, 2024 17:56

Pull request was closed

@christophe-papazian christophe-papazian enabled auto-merge (squash) October 30, 2024 18:01
@christophe-papazian christophe-papazian merged commit c37939f into main Oct 30, 2024
520 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/update_security_rules_1.13.2 branch October 30, 2024 19:09
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
Update security rules to
[1.13.2](https://github.com/DataDog/appsec-event-rules/releases/tag/1.13.2)

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit c37939f)
christophe-papazian added a commit that referenced this pull request Oct 30, 2024
Backport c37939f from #11227 to 2.16.

Update security rules to
[1.13.2](https://github.com/DataDog/appsec-event-rules/releases/tag/1.13.2)

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Christophe Papazian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring backport 2.16 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants