Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): update security rules to 1.13.2 [backport 2.16] #11233

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 30, 2024

Backport c37939f from #11227 to 2.16.

Update security rules to 1.13.2

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Update security rules to
[1.13.2](https://github.com/DataDog/appsec-event-rules/releases/tag/1.13.2)

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit c37939f)
@github-actions github-actions bot requested a review from a team as a code owner October 30, 2024 19:09
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Oct 30, 2024
@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Oct 30, 2024
Copy link
Contributor Author

CODEOWNERS have been resolved as:

ddtrace/appsec/rules.json                                               @DataDog/asm-python
tests/appsec/integrations/pygoat_tests/test_pygoat.py                   @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_body_no_collection_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_cookies_no_collection_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.appsec.appsec.test_processor.test_appsec_span_tags_snapshot.json  @DataDog/asm-python
tests/snapshots/tests.contrib.django.test_django_appsec_snapshots.test_appsec_enabled.json  @DataDog/asm-python
tests/snapshots/tests.contrib.django.test_django_appsec_snapshots.test_appsec_enabled_attack.json  @DataDog/asm-python

@christophe-papazian christophe-papazian enabled auto-merge (squash) October 30, 2024 19:11
@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024

Benchmarks

Benchmark execution time: 2024-10-30 19:45:45

Comparing candidate commit a179c6b in PR branch backport-11227-to-2.16 with baseline commit 61ef93b in branch 2.16.

Found 4 performance improvements and 0 performance regressions! Performance is the same for 370 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathsplitext_aspect

  • 🟩 execution_time [-330.673ns; -280.218ns] or [-8.510%; -7.212%]

scenario:iast_aspects-replace_aspect

  • 🟩 execution_time [-823.507ns; -738.545ns] or [-11.057%; -9.916%]

scenario:iast_aspects-rsplit_aspect

  • 🟩 execution_time [-209.305ns; -183.707ns] or [-11.164%; -9.799%]

scenario:iast_aspects-split_aspect

  • 🟩 execution_time [-195.816ns; -170.121ns] or [-10.623%; -9.229%]

@christophe-papazian christophe-papazian merged commit d9c062a into 2.16 Oct 30, 2024
520 checks passed
@christophe-papazian christophe-papazian deleted the backport-11227-to-2.16 branch October 30, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant