Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity between Python disk check and Go disk check #33116

Draft
wants to merge 72 commits into
base: main
Choose a base branch
from
+2,260 −324
Draft

Feature parity between Python disk check and Go disk check #33116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
5321bc8
add test when 'include_all_devices' is not present (default value=True)
jose-manuel-almaza Jan 20, 2025
2cebed1
add release notes
jose-manuel-almaza Jan 20, 2025
df8d05b
add test when 'include_all_devices' is True
jose-manuel-almaza Jan 20, 2025
5ed612e
add test when 'include_all_devices' is False
jose-manuel-almaza Jan 20, 2025
48b78e0
refactor mocks
jose-manuel-almaza Jan 20, 2025
2a2142d
add test when disk.Partitions returns an error
jose-manuel-almaza Jan 20, 2025
f145f53
add debug logs present in python check
jose-manuel-almaza Jan 20, 2025
447c523
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 21, 2025
8fb789f
add 'all_partitions' tests
jose-manuel-almaza Jan 22, 2025
1e6b88c
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 22, 2025
cc5c03c
process 'device_exclude' config key
jose-manuel-almaza Jan 22, 2025
59e568c
process 'device_blacklist' config key
jose-manuel-almaza Jan 22, 2025
8c98e0f
process 'excluded_disks' config key
jose-manuel-almaza Jan 22, 2025
56b2fc5
process 'excluded_disk_re' config key
jose-manuel-almaza Jan 22, 2025
e2abd45
move 'mountpoint' variable closer to its use
jose-manuel-almaza Jan 22, 2025
b514223
small refactor
jose-manuel-almaza Jan 23, 2025
479c31b
process 'device_include' and 'device_whitelist' config keys
jose-manuel-almaza Jan 23, 2025
ddd7058
process 'file_system_exclude', 'file_system_blacklist' and 'excluded_…
jose-manuel-almaza Jan 23, 2025
8b1d5fb
process 'file_system_include' and 'file_system_whitelist' config keys
jose-manuel-almaza Jan 23, 2025
7e7112f
process 'excluded_mountpoint_re' config key
jose-manuel-almaza Jan 23, 2025
931e6c1
process 'include_all_devices' config key
jose-manuel-almaza Jan 23, 2025
28588f1
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 23, 2025
54b6415
add regular expressions support when excluding devices
jose-manuel-almaza Jan 23, 2025
1220c2d
add regular expressions support when including devices
jose-manuel-almaza Jan 23, 2025
d83947b
add regular expressions support when including/excluding file systems
jose-manuel-almaza Jan 23, 2025
2b17c42
add regular expressions support when excluding mount points
jose-manuel-almaza Jan 23, 2025
5773ad9
process 'mount_point_include' and 'mount_point_whitelist' config keys
jose-manuel-almaza Jan 24, 2025
e458c39
add new asserts for all usage metrics reported
jose-manuel-almaza Jan 24, 2025
fda63ce
add new asserts for 'include_all_devices' config key tests
jose-manuel-almaza Jan 24, 2025
e0f1c42
meaningful test names and new asserts
jose-manuel-almaza Jan 24, 2025
60ce0ff
improve test names and add missing asserts
jose-manuel-almaza Jan 24, 2025
30ab96b
add test when 'diskUsage' system call returns error
jose-manuel-almaza Jan 24, 2025
17ea573
process 'device_global_exclude' and 'device_global_blacklist' config …
jose-manuel-almaza Jan 24, 2025
47b8407
add 'file_system_global_blacklist' deprecation message
jose-manuel-almaza Jan 24, 2025
d0fb680
remove comments
jose-manuel-almaza Jan 27, 2025
e655942
add 'device_global_blacklist' and 'mount_point_global_blacklist' depr…
jose-manuel-almaza Jan 27, 2025
096c7a5
process 'device_global_exclude' error in config
jose-manuel-almaza Jan 27, 2025
835a461
rename tests
jose-manuel-almaza Jan 27, 2025
cedcb2b
add 'file_system_whitelist' deprecation message
jose-manuel-almaza Jan 27, 2025
a53f049
add 'file_system_blacklist' deprecation message
jose-manuel-almaza Jan 27, 2025
6e95e4c
add 'device_whitelist' deprecation message
jose-manuel-almaza Jan 27, 2025
280d939
add 'device_blacklist' deprecation message
jose-manuel-almaza Jan 27, 2025
93d4b35
add 'mount_point_whitelist' deprecation message
jose-manuel-almaza Jan 27, 2025
ec812d4
add 'mount_point_blacklist' deprecation message
jose-manuel-almaza Jan 27, 2025
fc326c9
add 'excluded_filesystems' deprecation message
jose-manuel-almaza Jan 27, 2025
d2cc47d
add 'excluded_disks' and 'excluded_disk_re' deprecation message
jose-manuel-almaza Jan 27, 2025
a18c176
add 'excluded_mountpoint_re' deprecation message
jose-manuel-almaza Jan 27, 2025
c3678ee
process 'min_disk_size' config key
jose-manuel-almaza Jan 27, 2025
430f09d
assert log message when 'diskUsage' system call fails
jose-manuel-almaza Jan 27, 2025
cd36d33
assert log message when partition is excluded because of size check
jose-manuel-almaza Jan 27, 2025
56e3250
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 27, 2025
47328a1
process 'tag_by_filesystem' config key
jose-manuel-almaza Jan 27, 2025
789ebd9
process 'use_mount' config key
jose-manuel-almaza Jan 27, 2025
5b7d280
process 'device_tag_re' config key
jose-manuel-almaza Jan 28, 2025
eaae963
prevent using the 'use_lsblk' and 'blkid_cache_file' config keys at t…
jose-manuel-almaza Jan 28, 2025
c0efc48
small refactor
jose-manuel-almaza Jan 28, 2025
22fa311
process 'tag_by_label' config key
jose-manuel-almaza Jan 29, 2025
f5c2cd2
add test where 'tag_by_filesystem' configkey is false
jose-manuel-almaza Jan 29, 2025
7358e41
small refactor
jose-manuel-almaza Jan 29, 2025
6f9757e
process 'service_check_rw' config key
jose-manuel-almaza Jan 29, 2025
a103522
add tests for 'disk.IOCounters' use cases
jose-manuel-almaza Jan 29, 2025
e91c367
added logs
jose-manuel-almaza Jan 29, 2025
406ee23
update 'blkid' system call management
jose-manuel-almaza Jan 30, 2025
a1db57e
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 30, 2025
cf53230
add missing asserts
jose-manuel-almaza Jan 30, 2025
1a297ae
add labels to iocounters metrics
jose-manuel-almaza Jan 30, 2025
36bdaf4
remove some comments
jose-manuel-almaza Jan 30, 2025
2226c50
change warning log message to align with python version
jose-manuel-almaza Jan 31, 2025
82cf824
fix test name error
jose-manuel-almaza Jan 31, 2025
6625b63
fix test
jose-manuel-almaza Jan 31, 2025
46f5713
remove some default exclude values that should be set by config
jose-manuel-almaza Jan 31, 2025
1cc2d0d
use either device name or mount point to get device tags
jose-manuel-almaza Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading