Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity between Python disk check and Go disk check #33116

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

jose-manuel-almaza
Copy link
Contributor

@jose-manuel-almaza jose-manuel-almaza commented Jan 20, 2025

What does this PR do?

Implement missing features in Go's disk check compared to Python's disk check.
Tests and new code are added to cover these new features.
Some configuration keys were different and conflicted. Priority has been given to existing keys in Python's check since it is the most used one (currently Go's check is only run in IoT deployments). If the configuration keys currently used in Python's check are not found, the ones in Go's check are used.

Motivation

With the current Agent Kernel project, Python integrations will not be installed by default on new deployments.
This would result in the disk check that is currently running by default being lost and its metrics not being reported on those deployments.
This PR is intended to make this change in our default deployment transparent to the user.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

The information obtained from the system by the python and go modules for this functionality may be slightly different.

Additional Notes

@jose-manuel-almaza jose-manuel-almaza requested a review from a team January 20, 2025 12:28
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 20, 2025
@jose-manuel-almaza jose-manuel-almaza marked this pull request as draft January 20, 2025 12:28
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 20, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53941298 --os-family=ubuntu

Note: This applies to commit 47b8407

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 20, 2025

Uncompressed package size comparison

Comparison with ancestor 5b85f93d56196fd4d1da00bfbd8b140e28038829

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.02MB ⚠️ 477.86MB 477.83MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.02MB ⚠️ 94.01MB 93.99MB 0.50MB
datadog-iot-agent-x86_64-suse 0.02MB ⚠️ 94.00MB 93.98MB 0.50MB
datadog-iot-agent-amd64-deb 0.02MB ⚠️ 93.94MB 93.92MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 915.83MB 915.82MB 0.50MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 925.55MB 925.54MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 90.05MB 90.04MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 89.98MB 89.97MB 0.50MB
datadog-agent-amd64-deb 0.01MB ⚠️ 928.62MB 928.62MB 0.50MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 938.36MB 938.36MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 938.36MB 938.36MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.87MB 58.87MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.95MB 58.95MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.95MB 58.95MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.38MB 56.38MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Jan 20, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 00248f57-73d5-4509-b063-2e389655951f

Baseline: 5b85f93
Comparison: 47b8407
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.87 [-1.19, +4.94] 1 Logs
quality_gate_idle memory utilization +0.54 [+0.50, +0.58] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.39 [-0.50, +1.27] 1 Logs
quality_gate_idle_all_features memory utilization +0.23 [+0.18, +0.28] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.13 [-0.74, +0.99] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.08 [-0.70, +0.87] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.81, +0.92] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.61, +0.67] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.77, +0.80] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.89, +0.91] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.30, +0.29] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.82, +0.72] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.23 [-0.69, +0.24] 1 Logs
file_tree memory utilization -0.33 [-0.38, -0.27] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.99 [-1.06, -0.92] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 20, 2025
@jose-manuel-almaza jose-manuel-almaza added the qa/done QA done before merge and regressions are covered by tests label Jan 20, 2025
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant