Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the healthcheck step of the docker-compose MySQL file #388

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Dec 11, 2024

Description

Added/Changed/Fixed

  • The MariaDB healthcheck step in docker-compose-mysql.yml, preventing the demo app to start

How to test

  • Locally, run docker-compose -f docker-compose-mysql.yml --env-file template.env up

Expected outcome

  • The app should start without problems

Review

  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (719f1b8) to head (57a467d).
Report is 151 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   90.18%   92.60%   +2.41%     
==========================================
  Files          30       31       +1     
  Lines        1457     1514      +57     
==========================================
+ Hits         1314     1402      +88     
+ Misses        143      112      -31     
Flag Coverage Δ
unittests 92.60% <ø> (+2.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch
Copy link
Member Author

Main branch:

image

This branch:

image

@northwestwitch northwestwitch merged commit 83851f3 into main Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants