Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11299: Changed texts and translations for linkedevents #1193

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Feb 17, 2025

UHF-11299

What was done

  • Changed some texts and their translations

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11299
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-11299
  • Run make drush-updb drush-locale-update drush-cr

How to test

  • Create a landing page and add an event paragraph to it with all the booleans checked to true (not curated events) and translate the page to English, Finnish and swedish
  • In the edit form, make sure there isn't any more references to "Älä käytä yhtäaikaa etätapahtuma..." in Finnish and english
  • On the page, check that all the requested translations have been made in each language

Tapahtumapaikan label:
FI: Valitse tapahtumapaikka ⮕ Tapahtumapaikka
SV: Evenemangsplats
EN: Venue

Tapahtumapaikan placeholder:
FI: Kaikki ⮕ Kaikki tapahtumapaikat
SV: Alla evenemangsplatser
EN: All venues

Ajankohdan placeholder:
FI: Kaikki ⮕ Kaikki ajankohdat
SV: Alla tidpunkter
EN: All dates

Ajankohdan selitysteksti:
FI: Valitse ajankohta aikaväli, johon tapahtuma sijoittuu
SV: Sätt ut tidpunkterna inom vilka evenemanget ordnas
EN: Select a time period in which the event takes place

Hakutulosten jälkeen oleva button:
FI: Tarkenna hakua tapahtumat.hel.fissä ⮕ Etsi lisää tapahtumia Tapahtumat-sivustolta
SV: Sök fler evenemang på webbplatsen Evenemang
EN: Search for more events on the Events website

  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1193/html_report/

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🚀

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1193/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants