Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] Add service_bd_routing_disable attribute to aci_bridge_domain resource and datasource (DCNE-263) #1305

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/data-sources/bridge_domain.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ data "aci_bridge_domain" "example_tenant" {
* `pc_tag` (pcTag) - (string) The classification tag used for policy enforcement and zoning.
* `scope` (scope) - (string) The scope ID (L3-VNI) of the Bridge Domain object.
* `segment` (seg) - (string) The segment ID (L2-VNI) of the Bridge Domain object.
* `service_bd_routing_disable` (serviceBdRoutingDisable) - (string) Disable Routing on service BD.
* `bridge_domain_type` (type) - (string) The domain type of the Bridge Domain object.
* `unicast_routing` (unicastRoute) - (string) Enables L3 routing and endpoint IP learning for the Bridge Domain object.
* `l2_unknown_unicast_flooding` (unkMacUcastAct) - (string) The forwarding method for unknown layer 2 destinations.
Expand Down
4 changes: 4 additions & 0 deletions docs/resources/bridge_domain.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ resource "aci_bridge_domain" "full_example_tenant" {
name_alias = "name_alias_1"
owner_key = "owner_key_1"
owner_tag = "owner_tag_1"
service_bd_routing_disable = "no"
bridge_domain_type = "fc"
unicast_routing = "no"
l2_unknown_unicast_flooding = "proxy"
Expand Down Expand Up @@ -387,6 +388,9 @@ All examples for the Bridge Domain resource can be found in the [examples](https
* `scope` (scope) - (string) The scope ID (L3-VNI) of the Bridge Domain object.
- Default: `0`
* `segment` (seg) - (string) The segment ID (L2-VNI) of the Bridge Domain object.
* `service_bd_routing_disable` (serviceBdRoutingDisable) - (string) Disable Routing on service BD.
- Default: `no`
- Valid Values: `no`, `yes`.
* `bridge_domain_type` (type) - (string) The domain type of the Bridge Domain object.
- Default: `regular`
- Valid Values: `fc`, `regular`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ resource "aci_bridge_domain" "full_example_tenant" {
name_alias = "name_alias_1"
owner_key = "owner_key_1"
owner_tag = "owner_tag_1"
service_bd_routing_disable = "no"
bridge_domain_type = "fc"
unicast_routing = "no"
l2_unknown_unicast_flooding = "proxy"
Expand Down
72 changes: 61 additions & 11 deletions gen/meta/fvBD.json
Original file line number Diff line number Diff line change
Expand Up @@ -2046,7 +2046,7 @@
"isConfigurable": true,
"propGlobalId": "34472",
"propLocalId": "8158",
"label": "Optimize Wan Bandwidth between sites",
"label": "Optimize Wan Bandwidth Between Sites",
anvitha-jain marked this conversation as resolved.
Show resolved Hide resolved
"baseType": "scalar:Bool",
"modelType": "scalar:Bool",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -2176,7 +2176,7 @@
"isConfigurable": false,
"propGlobalId": "1691",
"propLocalId": "859",
"label": "bcastP",
"label": "Broadcast Policy",
"baseType": "address:IPv4",
"modelType": "mcast:Group",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -2251,7 +2251,7 @@
"isConfigurable": false,
"propGlobalId": "26448",
"propLocalId": "153",
"label": "configIssues",
"label": "Configuration Issues",
"baseType": "scalar:Bitmask64",
"modelType": "fv:BDConfIssuesType",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -2606,7 +2606,7 @@
"isConfigurable": true,
"propGlobalId": "30545",
"propLocalId": "7595",
"label": "Allow BUM traffic between sites",
"label": "Allow BUM Traffic Between Sites",
"baseType": "scalar:Bool",
"modelType": "scalar:Bool",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -2653,7 +2653,7 @@
"isConfigurable": true,
"propGlobalId": "33178",
"propLocalId": "7928",
"label": "Allow l2Stretch between sites",
"label": "Allow L2Stretch Between Sites",
"baseType": "scalar:Bool",
"modelType": "scalar:Bool",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -2697,7 +2697,7 @@
"isConfigurable": true,
"propGlobalId": "21254",
"propLocalId": "5433",
"label": "Ip Learning",
"label": "IP Learning",
"baseType": "scalar:Bool",
"modelType": "scalar:Bool",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -2744,7 +2744,7 @@
"isConfigurable": true,
"propGlobalId": "47406",
"propLocalId": "10834",
"label": "ipv6 Multicast Allow",
"label": "IPv6 Multicast Allow",
"baseType": "scalar:Bool",
"modelType": "scalar:Bool",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -2854,7 +2854,7 @@
"isConfigurable": true,
"propGlobalId": "20851",
"propLocalId": "5375",
"label": "Limit IP learning to BD subnets only",
"label": "Limit IP Learning to BD Subnets",
"baseType": "scalar:Bool",
"modelType": "scalar:Bool",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -3380,7 +3380,7 @@
"isConfigurable": false,
"propGlobalId": "1695",
"propLocalId": "551",
"label": "pcTag",
"label": "PC Tag",
"baseType": "scalar:Uint32",
"modelType": "vz:GPCTag",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -3445,7 +3445,7 @@
"isConfigurable": false,
"propGlobalId": "1694",
"propLocalId": "1",
"label": "scope",
"label": "Scope",
"baseType": "scalar:Uint32",
"modelType": "fv:ScopeId",
"needsPropDelimiters": false,
Expand Down Expand Up @@ -3503,6 +3503,56 @@
"isDeprecated": false,
"isHidden": false
},
"serviceBdRoutingDisable": {
"versions": "6.0(4c)-",
"comment": [
"Disable Routing on service BD"
],
"isConfigurable": true,
"propGlobalId": "70465",
"propLocalId": "15461",
"label": "Disable Routing on Service BD",
"baseType": "scalar:Bool",
"modelType": "scalar:Bool",
"needsPropDelimiters": false,
"uitype": "boolean",
"createOnly": false,
"readWrite": true,
"readOnly": false,
"isNaming": false,
"secure": false,
"implicit": false,
"mandatory": false,
"isOverride": false,
"isLike": false,
"validValues": [
{ "value": "no", "localName": "defaultValue",
"platformFlavors": [

],
"comment": [
"By default, routing is enabled on service BD"
],
"label": " "},
{ "value": "false", "localName": "no",
"platformFlavors": [

],
"label": "No "},
{ "value": "true", "localName": "yes",
"platformFlavors": [

],
"label": "Yes "}
],
"default": "no",
"platformFlavors": [

],
"isNxosConverged": false,
"isDeprecated": false,
"isHidden": false
},
"status": {
"versions": "1.0(1e)-",
"comment": [
Expand Down Expand Up @@ -3689,7 +3739,7 @@
"isConfigurable": true,
"propGlobalId": "1696",
"propLocalId": "886",
"label": "Unknown Mac Unicast Action",
"label": "Unknown MAC Unicast Action",
"baseType": "scalar:Enum8",
"modelType": "l2:UnkMacUcastAct",
"needsPropDelimiters": false,
Expand Down
4 changes: 4 additions & 0 deletions gen/testvars/fvBD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ default:
pim_ipv6: "no"
5.2(5c):
drop_arp_with_multicast_smac: "yes"
6.0(4c):
service_bd_routing_disable: "no"

datasource_non_existing:
name: "non_existing_name"
Expand Down Expand Up @@ -82,6 +84,8 @@ all:
pim_ipv6: "no"
5.2(5c):
drop_arp_with_multicast_smac: "no"
6.0(4c):
service_bd_routing_disable: "no"

children:
legacy_mode:
Expand Down
4 changes: 4 additions & 0 deletions internal/provider/data_source_aci_bridge_domain.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/provider/data_source_aci_bridge_domain_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions internal/provider/resource_aci_bridge_domain.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions internal/provider/resource_aci_bridge_domain_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading