Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Add service_bd_routing_disable attribute to aci_bridge_domain resource and datasource (DCNE-263) #1305

Merged
merged 1 commit into from
Jan 25, 2025
Merged

[minor_change] Add service_bd_routing_disable attribute to aci_bridge_domain resource and datasource (DCNE-263) #1305

merged 1 commit into from
Jan 25, 2025

Conversation

akinross
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.70%. Comparing base (fc60930) to head (dfd4143).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/provider/resource_aci_bridge_domain.go 65.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
+ Coverage   85.49%   85.70%   +0.20%     
==========================================
  Files         125      129       +4     
  Lines       70986    73582    +2596     
==========================================
+ Hits        60693    63067    +2374     
- Misses       8337     8500     +163     
- Partials     1956     2015      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sajagana
sajagana previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib added the jira-sync Sync this issue to Jira label Dec 3, 2024
@github-actions github-actions bot changed the title [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) (DCNE-264) Dec 3, 2024
@samiib samiib removed the jira-sync Sync this issue to Jira label Dec 3, 2024
@samiib samiib changed the title [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) (DCNE-264) [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) Dec 3, 2024
gmicol
gmicol previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross dismissed stale reviews from gmicol, samiib, shrsr, and sajagana via 14debd3 December 19, 2024 08:01
@akinross akinross force-pushed the 1304_missing_atttributes_aci_bridge_domain branch from c56a6ff to 14debd3 Compare December 19, 2024 08:01
@akinross akinross changed the title [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) [minor_change] Add service_bd_routing_disable attribute to aci_bridge_domain resource and datasource (DCNE-263) Dec 19, 2024
samiib
samiib previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmicol gmicol self-requested a review January 6, 2025 13:21
@shrsr shrsr self-requested a review January 7, 2025 16:36
shrsr
shrsr previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

anvitha-jain
anvitha-jain requested changes Jan 22, 2025
View reviewed changes
gen/meta/fvBD.json Show resolved Hide resolved
@akinross akinross requested a review from anvitha-jain January 23, 2025 08:22
anvitha-jain
anvitha-jain previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gen/meta/fvBD.json Show resolved Hide resolved
lhercot
lhercot requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a rebase

@akinross akinross dismissed stale reviews from anvitha-jain, sajagana, gmicol, shrsr, and samiib via dfd4143 January 25, 2025 10:00
@akinross akinross force-pushed the 1304_missing_atttributes_aci_bridge_domain branch from 14debd3 to dfd4143 Compare January 25, 2025 10:00
lhercot
lhercot approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 5dff413 into CiscoDevNet:master Jan 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhercot lhercot lhercot approved these changes

@shrsr shrsr Awaiting requested review from shrsr shrsr is a code owner

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

@samiib samiib Awaiting requested review from samiib samiib is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@akinross @codecov-commenter @lhercot @shrsr @anvitha-jain @sajagana @samiib @gmicol