Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for empty birthday when initially inputting person #6652

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

DAcodedBEAT
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Allow empty birthday when initially inputting Person to platform.

Issue ticket number and link

Closes #5985

How should this be manually tested?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Create a person without providing a birthday

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DAcodedBEAT DAcodedBEAT added Feature: Users php Pull requests that update Php code labels Nov 11, 2023
@DAcodedBEAT DAcodedBEAT requested review from DawoudIO, a team, MrClever and DiogoFilhoDeMorais and removed request for a team November 11, 2023 19:35
@DawoudIO DawoudIO modified the milestones: 5.2.1, 5.2.2 Nov 11, 2023
@DawoudIO DawoudIO merged commit 50b714d into master Nov 12, 2023
1 check passed
@DawoudIO DawoudIO deleted the allow-empty-birthday-on-person-input branch November 12, 2023 23:39
@DawoudIO DawoudIO mentioned this pull request Nov 14, 2023
@DawoudIO DawoudIO added the bug label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Feature: Users php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Birthday required when adding a new person
2 participants