Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Birthday required when adding a new person #5985

Closed
meichthys opened this issue Feb 13, 2022 · 3 comments · Fixed by #6652
Closed

Birthday required when adding a new person #5985

meichthys opened this issue Feb 13, 2022 · 3 comments · Fixed by #6652

Comments

@meichthys
Copy link
Contributor

It doesn't seem like a birthday should be required.

image

@OldManMozz
Copy link

It is a bug I believe.
Line 213 in PersonEditor.php reads:
} elseif (strlen($iBirthYear) > 0 && $iBirthMonth == 0 && $iBirthDay == 0) {
By default on the page Birth Year is set to 0, which has a string length of 1 so will always fail.
Changing line 213 to read:
} elseif ($iBirthYear > 0 && $iBirthMonth == 0 && $iBirthDay == 0) {
will fix the problem and allow the date of birth to be optional.

@yeison08
Copy link

I try your subjection and it work.
Thank you!!

@DAcodedBEAT
Copy link
Contributor

Thanks for the suggestion @OldManMozz !

I've made a Pull Request so this suggestion is upstreamed into the project: #6652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants