[DDING-000] 지원자 조회 API 수정

[Seooooo24]

🚀 작업 내용

FE 요구사항을 반영하고자 지원자 상세 조회 응답에 hasInterview를 추가했습니다.
이전 pr에서 생성자를 빌더로 바꾸면서 누락시킨 pagingInfo를 MyFormApplicationPageResponse에 추가했습니다.

🤔 고민했던 내용

💬 리뷰 중점사항

Summary by CodeRabbit

• New Features
  • 지원 내역에 면접 진행 여부 정보를 추가하여, 면접 연계 여부를 쉽게 확인할 수 있습니다.
  • 내 지원 목록 페이지에 페이징 정보가 제공되어 페이지 탐색이 개선되었습니다.
  • 지원 조회 결과에 양식 관련 추가 정보가 포함되어 상세한 지원 내역을 제공합니다.

[coderabbitai]

Walkthrough

이번 PR은 FormApplicationResponse와 FormApplicationQuery에 새로운 boolean 필드인 hasInterview를 추가하고, 해당 정보를 전달할 수 있도록 빌더 및 메서드를 수정합니다. 또한, MyFormApplicationPageResponse의 from 메서드에 pagingInfo 할당을 추가하며, FacadeCentralFormApplicationServiceImpl의 getFormApplication 메서드에서 formService를 호출하여 Form 객체를 조회한 후 결과에 포함시키는 로직을 도입합니다.

Changes

파일	변경 요약
src/.../dto/response/FormApplicationResponse.java, src/.../dto/query/FormApplicationQuery.java	새로운 boolean hasInterview 필드 추가 및 빌더/메서드 수정 (인터뷰 여부 반영)
src/.../dto/response/MyFormApplicationPageResponse.java	from 메서드 수정: pagingInfo 필드 할당 추가
src/.../service/FacadeCentralFormApplicationServiceImpl.java	getFormApplication 메서드에서 formService 호출로 Form 객체 조회 후 결과에 포함

Sequence Diagram(s)

sequenceDiagram
    participant C as Controller
    participant S as Facade Service
    participant F as FormService
    participant Q as FormApplicationQuery Builder

    C->>S: getFormApplication(formId, applicationId, user)
    S->>F: getById(formId)
    F-->>S: Form 객체 반환
    S->>Q: FormApplicationQuery.of(Form, formApplication, formAnswers)
    Q-->>S: Query 객체 생성
    S-->>C: Query 객체 반환

Loading

Possibly related PRs

• [DDING-95] 지원자 상세 조회 API 구현 #240: FormApplicationResponse 및 FormApplicationQuery 클래스 관련 변경 사항과 인터뷰 필드 추가에 대해 코드 수준에서 연관성이 있음.

Suggested labels

🎯리팩토링, 🛠️버그, D-2

Suggested reviewers

• wonjunYou
• 5uhwann
• KoSeonJe

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb52e2e and a489d41.

📒 Files selected for processing (4)

• src/main/java/ddingdong/ddingdongBE/domain/formapplication/controller/dto/response/FormApplicationResponse.java (1 hunks)
• src/main/java/ddingdong/ddingdongBE/domain/formapplication/controller/dto/response/MyFormApplicationPageResponse.java (1 hunks)
• src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/FacadeCentralFormApplicationServiceImpl.java (1 hunks)
• src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/dto/query/FormApplicationQuery.java (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build and analyze

🔇 Additional comments (6)

src/main/java/ddingdong/ddingdongBE/domain/formapplication/controller/dto/response/MyFormApplicationPageResponse.java (2)

13-27: 레코드 구조가 잘 설계되어 있습니다!

Swagger 어노테이션을 통한 문서화가 잘 되어있으며, 프론트엔드 요구사항에 맞게 hasInterview 필드가 적절히 추가되었습니다.

---

29-43: 페이징 정보가 올바르게 추가되었습니다!

빌더 패턴 변경 이후 누락되었던 pagingInfo 할당이 적절하게 추가되었습니다. 코드가 깔끔하고 일관성 있게 구현되어 있습니다.

src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/dto/query/FormApplicationQuery.java (2)

17-17: 새로운 필드 추가가 적절히 이루어졌습니다.

hasInterview 필드가 record에 잘 추가되었습니다.

---

52-66: 🏁 Script executed:

#!/bin/bash
# FormApplicationResponse에서 hasInterview 필드 매핑 여부 확인
rg "hasInterview" src/main/java/ddingdong/ddingdongBE/domain/formapplication/controller/dto/response/FormApplicationResponse.java

Length of output: 155

src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/FacadeCentralFormApplicationServiceImpl.java (1)

50-53: Form 객체 조회 및 전달이 적절히 구현되었습니다.

Form 객체를 조회하여 FormApplicationQuery 생성 시 전달하는 로직이 잘 구현되었습니다.

src/main/java/ddingdong/ddingdongBE/domain/formapplication/controller/dto/response/FormApplicationResponse.java (1)

17-18: Schema 어노테이션이 적절히 추가되었습니다.

hasInterview 필드에 대한 설명과 예시가 명확하게 문서화되었습니다.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[KoSeonJe]

확인하였습니다