Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDING-001] 응답 dto 이메일 전화번호 추가 #260

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

Seooooo24
Copy link
Collaborator

@Seooooo24 Seooooo24 commented Feb 12, 2025

🚀 작업 내용

지원자 상세 조회 응답 dto에 이메일과 전화번호 추가하였습니다.

🤔 고민했던 내용

💬 리뷰 중점사항

Summary by CodeRabbit

  • 새로운 기능
    • 양식 제출 과정에 연락처 입력 옵션이 강화되었습니다.
    • 이제 사용자는 전화번호와 이메일 정보를 추가로 입력할 수 있어, 제출 정보의 정확성과 후속 소통에 도움이 됩니다.

Copy link

coderabbitai bot commented Feb 12, 2025

Walkthrough

이 PR은 FormApplicationResponseFormApplicationQuery 레코드에 phoneNumberemail 필드를 추가합니다. 각 레코드의 팩토리 메서드(from, of)가 업데이트되어 새로운 필드의 값을 반영하도록 변경되었습니다. 추가된 필드는 문서화 어노테이션(@Schema)로 설명이 포함되어 있으며, 관련 데이터 소스에서 값을 가져오도록 구현되었습니다.

Changes

파일 변경 요약
src/.../dto/response/FormApplicationResponse.java, src/.../dto/query/FormApplicationQuery.java 두 레코드에 phoneNumberemail 필드를 추가하고, 팩토리 메서드(from, of)를 업데이트하여 해당 값들을 반영함

Possibly related PRs

Suggested labels

🎯리팩토링, D-0

Suggested reviewers

  • wonjunYou
  • 5uhwann
  • KoSeonJe

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94f1b34 and 7928c41.

📒 Files selected for processing (2)
  • src/main/java/ddingdong/ddingdongBE/domain/formapplication/controller/dto/response/FormApplicationResponse.java (2 hunks)
  • src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/dto/query/FormApplicationQuery.java (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and analyze
🔇 Additional comments (4)
src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/dto/query/FormApplicationQuery.java (2)

22-23: 필드 추가가 적절하게 이루어졌습니다!

전화번호와 이메일 필드가 레코드에 잘 추가되었습니다. String 타입의 사용이 적절합니다.


65-66: 팩토리 메서드 업데이트가 올바르게 구현되었습니다!

새로 추가된 필드들이 기존 패턴을 따라 일관성 있게 구현되었습니다.

src/main/java/ddingdong/ddingdongBE/domain/formapplication/controller/dto/response/FormApplicationResponse.java (2)

27-30: 스키마 문서화가 잘 되어있습니다!

전화번호와 이메일 필드에 대한 @Schema 어노테이션이 명확하게 작성되었으며, 예시 값도 적절합니다.


86-87: 팩토리 메서드 업데이트가 올바르게 구현되었습니다!

새로 추가된 필드들이 기존 패턴을 따라 일관성 있게 구현되었습니다.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Seooooo24 Seooooo24 added the D-0 label Feb 12, 2025
@Seooooo24 Seooooo24 changed the title Refactor/dding 001 [DDING-001] 응답 dto 이메일 전화번호 추가 Feb 12, 2025
Copy link
Collaborator

@KoSeonJe KoSeonJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다

@Seooooo24 Seooooo24 merged commit 1723f2b into develop Feb 12, 2025
4 checks passed
@Seooooo24 Seooooo24 deleted the refactor/DDING-001 branch February 12, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants