running with dan latest vtk-cdat #401
Conversation
|
This was just to test the updated build here. |
vcs/vcsvtk/fillareautils.py
Outdated
| @@ -63,7 +63,8 @@ def computeMarkerScale(dataRange, screenGeom, pxScale=None): | |||
| # screenAspect = float(screenGeom[0]) / screenGeom[1] | |||
|
|
|||
| scale = max(*diffwpoints) | |||
| if dataAspect > 1: | |||
| print("DA") | |||
| if dataAspect < 1: | |||
There was a problem hiding this comment.
@doutriaux1 @danlipsa This is the change that is causing the changes in marker size and the "black screen" (which just really huge markers) on this branch. This must have slipped in somehow from our experimentation while I was visiting.
As @doutriaux1 and I discussed a couple weeks ago, I'm going to revisit the handling of marker size again soon enough anyway, but I'll push a commit removing this and then create a vtk_master branch on the baseline repo and see if we can't get this though so we can really start taking @danlipsa latest VTK build.
There was a problem hiding this comment.
Good you found it. Not sure why I have not seen this. I was testing with master - maybe I did not pull the latest, or was this on a branch?
scottwittenburg
force-pushed
the
vtk_master
branch
from
30bdac5 to
0076ec4
Compare
|
Baselines for this PR are located here. |
|
Let's see how this does on circle @doutriaux1 and @danlipsa. With the new baselines for isofill and streamline, it passed all the tests for me. |
|
@scottwittenburg this looks good. I'll need to take Dan's recipe then and build the python 3.7 binaries and switch back to using our channel/nightly then we can merge in master |
|
Yep, sounds good. Thanks @doutriaux1. |
|
@danlipsa yes I had accidentally pushed it to |
No description provided.