Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vtk new module system #62

Merged
merged 20 commits into from
Apr 23, 2019
Merged

Vtk new module system #62

merged 20 commits into from
Apr 23, 2019

Conversation

danlipsa
Copy link
Contributor

No description provided.

danlipsa and others added 20 commits December 12, 2018 15:17
@danlipsa
Improve documentation.
896ea1a
@danlipsa
Pull from CDAT VTK branch
c57993c 
This is not yet merged into VTK master because of a Windows test.
Will revert to VTK master once this is merged.
@danlipsa
Upgrade to toolchain-7 (gcc 7.3)
11ff0fb
@danlipsa
toolchain3 is not needed on mac
b6a4787
@danlipsa
Use compiler('cxx') for mac.
570883a
@danlipsa
Patch from hand build dynamic load libraries.
c5b2324
@danlipsa
Use weak linking version for libvtkPythonInterpreter.
e976b8f
@danlipsa
Move to python 3.7
a683c59
@doutriaux1
trying py37 no_coverage needed
a0290d2
@scottwittenburg
Make some changes to build under the new module system
89097c0
@scottwittenburg
Add a few more fixes supporting the new module system
b16866d
@scottwittenburg
Make extra sure we get the modules we need
ea8dd76
@scottwittenburg
Prepare to use master
b689810
@scottwittenburg
Remove ViewsGeoVis module, and try another VTK branch that became nec…
8cdc038 
…essary
@scottwittenburg
Need to find that library on linux too, obviously.
e46f8dc 
Unfortunately, the find command differs so much between osx and linux
when using the -regex option (find -D needed on osx, and the or bar '|'
needs escape on linux, or else the -regex-type posix-extended arg is
needed), that I could not find a portable way to do this on one line.
@danlipsa
Fix finding correct python and remove cmake.
ab1584f 
CMake > 3.13 is needed but that conflicts with other libraries.
So we install it in conda root.
@danlipsa
VTK builds with compiler("cxx")
bc8a3b0
@danlipsa
Centos6 docker for looking at CDT packages.
d961aff
@danlipsa
Pull from master.
180fe33
@danlipsa
Enable PYTHON_OPTIONAL_LINK
695bff2
@danlipsa
Copy link
Contributor Author

@doutriaux1 @scottwittenburg Please review.
After we test 1730 version of packages
https://anaconda.org/danlipsa/vtk-cdat
let's merge this. We could get rid of the redhat docker (I left it there for now). The centos6 docker was very useful to figure out what CDT packages we need, but probably it won't be that needed in the future. I would leave it in there though.

@scottwittenburg scottwittenburg mentioned this pull request Apr 17, 2019
Merged
@scottwittenburg
Copy link
Contributor

I think this is looking good so far, the build failures on that PR I linked are expected, as a few spurious triangles were remove from several isofill plots by some fix made to VTK since we updated last. I'll just need to create a new branch in the baselines repo and then make some small change to vcs to pick it up.

@danlipsa
Copy link
Contributor Author

@scottwittenburg Great. Let me know when you you've done that. I would be great to merge this so that is out of the way. Thanks!

@doutriaux1 doutriaux1 merged commit 7ca802d into CDAT:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danlipsa @scottwittenburg @doutriaux1