forked from valkey-io/valkey-glide
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Redis client configuration logic #104
Merged
Merged
Changes from 7 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
731bfbb
Implement Redis client configuration logic
aaron-congo e4526af
Change default uint32 fields to *uint32
aaron-congo 364386f
Add gofumpt
aaron-congo 111f656
Add struct validation logic
aaron-congo 6dfc602
Format line length
aaron-congo 5cf5784
Format with fumpt
aaron-congo 9f76bad
Move build tool versions to makefile
aaron-congo 28ead19
Fix makefile lint/format targets
aaron-congo 59c53e6
Download old version of staticcheck if using go 1.18
aaron-congo 6cd71e4
Uncomment install commands
aaron-congo 2143942
Add make target to install go1.18 tools
aaron-congo dfe3e32
Fix incorrect version number
aaron-congo 39177c2
Add golines to tool installations
aaron-congo e5ed300
Add debug step to GH actions
aaron-congo 43d9a13
Remove goimports as a tool dependency
aaron-congo 7f5059d
PR suggestions
aaron-congo e223baf
Remove typo
aaron-congo 6ae23a1
Improve makefile targets and target names
aaron-congo 8f12115
Fix incorrect dev tool versions in makefile
aaron-congo 8b8971b
Change editorconfig defaults for Go
aaron-congo 81c58af
Update CI to run against Go 1.22
aaron-congo 0fab94a
Add DEVELOPER.md
aaron-congo 7eb12fd
PR suggestions
aaron-congo 810791f
Change struct fields to no longer be pointers
aaron-congo ae473a8
PR suggestions
aaron-congo d046752
Fix makefile target name
aaron-congo 6301ca6
PR suggestions
aaron-congo a62b9fe
PR suggestions
aaron-congo 50286f1
PR suggestions
aaron-congo 3422c91
Add clientName field
aaron-congo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
install-tools: | ||
@cat tools.go | grep _ | awk -F'"' '{print $$2}' | xargs -tI % go install % | ||
go install github.com/vakenbolt/[email protected] | ||
Yury-Fridlyand marked this conversation as resolved.
Show resolved
Hide resolved
|
||
go install google.golang.org/protobuf/cmd/[email protected] | ||
go install honnef.co/go/tools/cmd/[email protected] | ||
go install mvdan.cc/[email protected] | ||
go install golang.org/x/tools/cmd/[email protected] | ||
|
||
build: build-glide-core build-glide-client generate-protobuf | ||
go build ./... | ||
|
@@ -23,7 +27,14 @@ generate-protobuf: | |
lint: | ||
go vet ./... | ||
staticcheck ./... | ||
if [ "$(gofmt -s -l . | wc -l)" -gt 0 ]; then return 1; fi | ||
if [ "$$(gofumpt -l . | wc -l)" -gt 0 ]; then exit 1; fi | ||
if [ "$$(golines -l --shorten-comments -m 127 . | wc -l)" -gt 0 ]; then exit 1; fi | ||
if [ "$$(goimports -l . | wc -l)" -gt 0 ]; then exit 1; fi | ||
|
||
format: | ||
gofumpt -w . | ||
golines -w --shorten-comments -m 127 . | ||
goimports -w . | ||
|
||
unit-test-report: | ||
mkdir -p reports | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using linter for makefile too (later)