Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Redis client configuration logic #104

Merged
merged 30 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
731bfbb
Implement Redis client configuration logic
aaron-congo Feb 7, 2024
e4526af
Change default uint32 fields to *uint32
aaron-congo Feb 21, 2024
364386f
Add gofumpt
aaron-congo Feb 21, 2024
111f656
Add struct validation logic
aaron-congo Feb 21, 2024
6dfc602
Format line length
aaron-congo Feb 21, 2024
5cf5784
Format with fumpt
aaron-congo Feb 21, 2024
9f76bad
Move build tool versions to makefile
aaron-congo Feb 21, 2024
28ead19
Fix makefile lint/format targets
aaron-congo Feb 21, 2024
59c53e6
Download old version of staticcheck if using go 1.18
aaron-congo Feb 21, 2024
6cd71e4
Uncomment install commands
aaron-congo Feb 21, 2024
2143942
Add make target to install go1.18 tools
aaron-congo Feb 22, 2024
dfe3e32
Fix incorrect version number
aaron-congo Feb 22, 2024
39177c2
Add golines to tool installations
aaron-congo Feb 22, 2024
e5ed300
Add debug step to GH actions
aaron-congo Feb 22, 2024
43d9a13
Remove goimports as a tool dependency
aaron-congo Feb 22, 2024
7f5059d
PR suggestions
aaron-congo Feb 22, 2024
e223baf
Remove typo
aaron-congo Feb 22, 2024
6ae23a1
Improve makefile targets and target names
aaron-congo Feb 22, 2024
8f12115
Fix incorrect dev tool versions in makefile
aaron-congo Feb 22, 2024
8b8971b
Change editorconfig defaults for Go
aaron-congo Feb 22, 2024
81c58af
Update CI to run against Go 1.22
aaron-congo Feb 22, 2024
0fab94a
Add DEVELOPER.md
aaron-congo Feb 22, 2024
7eb12fd
PR suggestions
aaron-congo Feb 22, 2024
810791f
Change struct fields to no longer be pointers
aaron-congo Feb 27, 2024
ae473a8
PR suggestions
aaron-congo Feb 27, 2024
d046752
Fix makefile target name
aaron-congo Feb 27, 2024
6301ca6
PR suggestions
aaron-congo Feb 27, 2024
a62b9fe
PR suggestions
aaron-congo Feb 27, 2024
50286f1
PR suggestions
aaron-congo Feb 28, 2024
3422c91
Add clientName field
aaron-congo Feb 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions go/Makefile

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using linter for makefile too (later)

Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
install-tools:
@cat tools.go | grep _ | awk -F'"' '{print $$2}' | xargs -tI % go install %
go install github.com/vakenbolt/[email protected]
Yury-Fridlyand marked this conversation as resolved.
Show resolved Hide resolved
go install google.golang.org/protobuf/cmd/[email protected]
go install honnef.co/go/tools/cmd/[email protected]
go install mvdan.cc/[email protected]
go install golang.org/x/tools/cmd/[email protected]

build: build-glide-core build-glide-client generate-protobuf
go build ./...
Expand All @@ -23,7 +27,14 @@ generate-protobuf:
lint:
go vet ./...
staticcheck ./...
if [ "$(gofmt -s -l . | wc -l)" -gt 0 ]; then return 1; fi
if [ "$$(gofumpt -l . | wc -l)" -gt 0 ]; then exit 1; fi
if [ "$$(golines -l --shorten-comments -m 127 . | wc -l)" -gt 0 ]; then exit 1; fi
if [ "$$(goimports -l . | wc -l)" -gt 0 ]; then exit 1; fi

format:
gofumpt -w .
golines -w --shorten-comments -m 127 .
goimports -w .

unit-test-report:
mkdir -p reports
Expand Down
Loading
Loading