Implement Redis client configuration logic

.github/workflows/go.yml

@@ -29,8 +29,8 @@ jobs:
             fail-fast: false
             matrix:
                 go:
-                    - '1.18'
-                    - '1.21'
+                    - '1.18.10'
+                    - '1.22.0'
                 redis:
                     - 6.2.14
                     - 7.2.3
@@ -65,21 +65,21 @@ jobs:
               with:
                   redis-version: ${{ matrix.redis }}
 
-            - name: Install client dependencies
+            - name: Install tools for Go ${{ matrix.go }}
               working-directory: ./go
-              run: make install-tools
+              run: make install-tools-go${{ matrix.go }}
 
             - name: Build client
               working-directory: ./go
               run: make build
 
             - name: Run linters
               working-directory: ./go
-              run: make lint
+              run: make lint-ci
 
-            - name: Run unit tests
+            - name: Run tests
               working-directory: ./go
-              run: make unit-test-report
+              run: make test-and-report
 
             - name: Upload test reports
               if: always()
@@ -88,7 +88,7 @@ jobs:
               with:
                   name: test-reports-go-${{ matrix.go }}-redis-${{ matrix.redis }}-${{ matrix.os }}
                   path: |
-                      go/reports/unit-test-report.html
+                      go/reports/test-report.html
 
     build-amazonlinux-latest:
         if: github.repository_owner == 'aws'
@@ -98,7 +98,7 @@ jobs:
             matrix:
                 go:
                     - 1.18.10
-                    - 1.21.6
+                    - 1.22.0
         runs-on: ubuntu-latest
         container: amazonlinux:latest
         timeout-minutes: 15
@@ -140,29 +140,29 @@ jobs:
                   echo "/usr/local/go/bin" >> $GITHUB_PATH
                   echo "$HOME/go/bin" >> $GITHUB_PATH
 
-            - name: Install client dependencies
+            - name: Install tools for Go ${{ matrix.go }}
               working-directory: ./go
-              run: make install-tools
+              run: make install-tools-go${{ matrix.go }}
 
             - name: Build client
               working-directory: ./go
               run: make build
 
             - name: Run linters
               working-directory: ./go
-              run: make lint
+              run: make lint-ci
 
-            - name: Run unit tests
+            - name: Run tests
               working-directory: ./go
-              run: make unit-test-report
+              run: make test-and-report
 
             - name: Upload test reports
               if: always()
               continue-on-error: true
               uses: actions/upload-artifact@v4
               with:
                   name: test-reports-go-${{ matrix.go }}-amazon-linux-latest
-                  path: go/reports/unit-test-report.html
+                  path: go/reports/test-report.html
 
     lint-rust:
         timeout-minutes: 15

go/DEVELOPER.md

@@ -0,0 +1,213 @@
+# Developer Guide
+
+This document describes how to set up your development environment to build and test the GLIDE for Redis Go wrapper.
+
+### Development Overview
+
+We're excited to share that the GLIDE Go client is currently in development! However, it's important to note that this client is a work in progress and is not yet complete or fully tested. Your contributions and feedback are highly encouraged as we work towards refining and improving this implementation. Thank you for your interest and understanding as we continue to develop this Go wrapper.
+
+The GLIDE for Redis Go wrapper consists of both Go and Rust code. The Go and Rust components communicate in two ways:
+1. Using the [protobuf](https://github.com/protocolbuffers/protobuf) protocol.
+2. Using shared C objects. [cgo](https://pkg.go.dev/cmd/cgo) is used to interact with the C objects from Go code.
+
+### Build from source
+
+#### Prerequisites
+
+Software Dependencies
+
+-   Go
+-   GNU Make
+-   git
+-   GCC
+-   pkg-config
+-   protoc (protobuf compiler) >= v3.20.0
+-   openssl
+-   openssl-dev
+-   rustup
+-   redis
+
+**Redis installation**
+
+To install redis-server and redis-cli on your host, follow the [Redis Installation Guide](https://redis.io/docs/install/install-redis/).
+
+**Dependencies installation for Ubuntu**
+
+```bash
+sudo apt update -y
+sudo apt install -y git gcc pkg-config openssl libssl-dev unzip make
+# Install Go
+sudo snap install go --classic
+export PATH="$PATH:$HOME/go/bin"
+# Install rust
+curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
+source "$HOME/.cargo/env"
+# Check that the Rust compiler is installed
+rustc --version
+# Install protobuf compiler
+PB_REL="https://github.com/protocolbuffers/protobuf/releases"
+curl -LO $PB_REL/download/v3.20.3/protoc-3.20.3-linux-x86_64.zip
+unzip protoc-3.20.3-linux-x86_64.zip -d $HOME/.local
+export PATH="$PATH:$HOME/.local/bin"
+# Check that the protobuf compiler is installed. A minimum version of 3.20.0 is required.
+protoc --version
+```
+
+**Dependencies installation for CentOS**
+
+```bash
+sudo yum update -y
+sudo yum install -y git gcc pkgconfig openssl openssl-devel unzip wget tar
+# Install Go
+wget https://go.dev/dl/go1.22.0.linux-amd64.tar.gz
+sudo tar -C /usr/local -xzf go1.22.0.linux-amd64.tar.gz
+export PATH="$PATH:/usr/local/go/bin"
+export PATH="$PATH:$HOME/go/bin"
+# Install rust
+curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
+source "$HOME/.cargo/env"
+# Check that the Rust compiler is installed
+rustc --version
+# Install protobuf compiler
+PB_REL="https://github.com/protocolbuffers/protobuf/releases"
+curl -LO $PB_REL/download/v3.20.3/protoc-3.20.3-linux-x86_64.zip
+unzip protoc-3.20.3-linux-x86_64.zip -d $HOME/.local
+export PATH="$PATH:$HOME/.local/bin"
+# Check that the protobuf compiler is installed. A minimum version of 3.20.0 is required.
+protoc --version
+```
+
+**Dependencies installation for MacOS**
+
+```bash
+brew update
+brew install go make git gcc pkgconfig protobuf@3 openssl
+export PATH="$PATH:$HOME/go/bin"
+curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
+source "$HOME/.cargo/env"
+# Check that the protobuf compiler is installed. A minimum version of 3.20.0 is required.
+protoc --version
+# Check that the Rust compiler is installed
+rustc --version
+```
+
+#### Building and installation steps
+
+Before starting this step, make sure you've installed all software requirements.
+
+1. Clone the repository:
+    ```bash
+    VERSION=0.1.0 # You can modify this to other released version or set it to "main" to get the unstable branch
+    git clone --branch ${VERSION} https://github.com/aws/glide-for-redis.git
+    cd glide-for-redis
+    ```
+2. Initialize git submodule:
+    ```bash
+    git submodule update --init --recursive
+    ```
+3. Install build dependencies:
+    ```bash
+    cd go
+    make install-build-tools
+    ```
+4. Build the Go wrapper:
+    ```bash
+    make build
+    ```
+5. Run tests:
+    1. Ensure that you have installed redis-server and redis-cli on your host. You can find the Redis installation guide at the following link: [Redis Installation Guide](https://redis.io/docs/install/install-redis/install-redis-on-linux/).
+    2. Execute the following command from the go folder:
+        ```bash
+        go test -race ./...
+        ```
+6. Install Go development tools with:
+
+    ```bash
+    make install-dev-tools
+    ```
+
+### Test
+
+To run tests, use the following command:
+
+```bash
+go test -race ./...
+```
+
+For more detailed test output, add the `-v` flag:
+
+```bash
+go test -race ./... -v
+```
+
+To execute a specific test, include `-run <test_name>`. For example:
+
+```bash
+go test -race ./... -run TestConnectionRequestProtobufGeneration_allFieldsSet -v
+```
+
+### Submodules
+
+After pulling new changes, ensure that you update the submodules by running the following command:
+
+```bash
+git submodule update
+```
+
+### Generate protobuf files
+
+During the initial build, Go protobuf files were created in `go/protobuf`. If modifications are made to the protobuf definition files (.proto files located in `glide-core/src/protobuf`), it becomes necessary to regenerate the Go protobuf files. To do so, run:
+
+```bash
+make generate-protobuf
+```
+
+
+### Linters
+
+Development on the Go wrapper may involve changes in either the Go or Rust code. Each language has distinct linter tests that must be passed before committing changes.
+
+#### Language-specific Linters
+
+**Go:**
+
+-   go vet
+-   gofumpt
+-   staticcheck
+-   golines
+
+**Rust:**
+
+-   clippy
+-   fmt
+
+#### Running the linters
+
+Run from the main `/go` folder
+
+1. Go
+    ```bash
+    make install-dev-tools
+    make lint
+    ```
+2. Rust
+    ```bash
+    rustup component add clippy rustfmt
+    cargo clippy --all-features --all-targets -- -D warnings
+    cargo fmt --manifest-path ./Cargo.toml --all
+    ```
+
+#### Fixing lint formatting errors
+
+The following command can be used to fix Go formatting errors reported by gofumpt or golines. Note that golines does not always format comments well if they surpass the max line length (127 characters).
+
+Run from the main `/go` folder
+
+```bash
+make format
+```
+
+### Recommended extensions for VS Code
+
+-   [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go)
+-   [rust-analyzer](https://marketplace.visualstudio.com/items?itemName=rust-lang.rust-analyzer)

go/Makefile

@@ -1,5 +1,25 @@
-install-tools:
-	@cat tools.go | grep _ | awk -F'"' '{print $$2}' | xargs -tI % go install %
+install-build-tools:
+	go install google.golang.org/protobuf/cmd/[email protected]
+
+install-dev-tools-go1.18:
+	go install github.com/vakenbolt/[email protected]
+	go install mvdan.cc/[email protected]
+	go install github.com/segmentio/[email protected]
+	go install honnef.co/go/tools/cmd/[email protected]
+
+install-dev-tools-go1.22:
+	go install github.com/vakenbolt/[email protected]
+	go install mvdan.cc/[email protected]
+	go install github.com/segmentio/[email protected]
+	go install honnef.co/go/tools/cmd/[email protected]
+
+install-dev-tools: install-dev-tools-go1.22
+
+install-tools-go1.18.10: install-build-tools install-dev-tools-go1.18
+
+install-tools-go1.22.0: install-build-tools install-dev-tools-go1.22
+
+install-tools: install-tools-go1.22.0
 
 build: build-glide-core build-glide-client generate-protobuf
 	go build ./...
@@ -23,7 +43,22 @@ generate-protobuf:
 lint:
 	go vet ./...
 	staticcheck ./...
+	gofumpt -d .
+	golines --dry-run --shorten-comments -m 127 .
+
+lint-ci:
+	go vet ./...
+	staticcheck ./...
+	if [ "$$(gofumpt -l . | wc -l)" -gt 0 ]; then exit 1; fi
+	if [ "$$(golines -l --shorten-comments -m 127 . | wc -l)" -gt 0 ]; then exit 1; fi
+
+format:
+	gofumpt -w .
+	golines -w --shorten-comments -m 127 .
+
+test:
+	go test -race ./...
 
-unit-test-report:
+test-and-report:
 	mkdir -p reports
-	go test -race ./... -json | go-test-report -o reports/unit-test-report.html
+	go test -race ./... -json | go-test-report -o reports/test-report.html