Split output of failurelogs' list results #4015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
bitoku and
fahlmant
as code owners
tsatam
force-pushed
the
tsatam/ARO-13611-split-failurelogs-output
branch
from
378d452 to
0869bcf
Compare
tsatam
force-pushed
the
tsatam/ARO-13611-split-failurelogs-output
branch
from
0869bcf to
bb504e1
Compare
edisonLcardenas
approved these changes
Dec 18, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-13611
What this PR does / why we need it:
This PR splits the logging output of k8s resource lists emitted during operation failures to output one object per-line, and to also log a "summary" of all objects (somewhat resembling
oc get ${RESOURCE}'s default output format).This is necessary as our log viewer has a presentation limit of 32767 characters per-field. This makes some output, such as our cluster operator output, currently unusable due to the sheer size of the list.
This PR also switches the JSON output from MarshalIndent to Marshal - in order to further reduce the character count of the resulting field. We can use tools such as
jqor KQL'sparse_jsonto consume this output and "re-pretty-print" if necessary.Test plan for issue:
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Above tests will ensure this change has no unintended effects on production flows.