Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Hive CD on install failures #4026

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

tsatam
Copy link
Collaborator

@tsatam tsatam commented Dec 19, 2024

HOLD until #4015 is merged, and its commits are dropped from this branch.

Which issue this PR addresses:

Fixes ARO-13781

What this PR does / why we need it:

  • Logs Hive CD on install failures

Test plan for issue:

  • Unit tests were added/updated to handle this

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

If we see Hive CDs in RP logs when an install fails, we'll know

@tsatam tsatam added the hold Hold label Dec 19, 2024
Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can revisit with official approval once the other PR merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants