ChibiOS: avoid bdshot fault on null event waiter #29379
Open
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gives a crash dump for easier analysis. Don't enable on production aircraft
tridge
force-pushed
the
pr-bdshot-crash-fix
branch
from
f54e962 to
cb67ae5
Compare
|
@andyp1per we need to know when this was introduced too, so we know if this could happen in 4.5.x |
tpwrules
reviewed
Feb 26, 2025
Comment on lines
+629
to
+630
| enable this on H7 to make writes to the first 1k of RAM on H7 | ||
| produce a hard fault and crash dump |
There was a problem hiding this comment.
Suggested change
| enable this on H7 to make writes to the first 1k of RAM on H7 | |
| produce a hard fault and crash dump | |
| enable this on H7 to make writes to the first 1k of RAM on H7 | |
| produce a hard fault and crash dump instead of an internal error. | |
| do not enable on production aircraft! |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a write to a null pointer in bdshot if the waiter is set to null while a timer is still pending
@andyp1per it would be good to get your input. This fix is more of a bandaid than a real fix
This fixes #29370