AP_GPS: speed up ublox configuration #29378
Open
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we have a lot more steps now to configure a ublox, and it is taking an annoyingly long time. There is really not a good reason to do the configuration so slowly on a F9P this reduces the time for configuration from detection of the ublox to fully configured from 35s to 10s
peterbarker
reviewed
Feb 26, 2025
| } | ||
| if (_unconfigured_messages) { | ||
| // send the updates faster until fully configured | ||
| _delay_time = 200; |
There was a problem hiding this comment.
Why such a long delay here still? What's the problem with just rapid-firing these things? A comment in here might be useful if there's a good reason!
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
|
Tested this on a few uBlox devices today and all seemed to go well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a lot more steps now to configure a ublox, and it is taking an annoyingly long time. There is really not a good reason to do the configuration so slowly
on a F9P this reduces the time for configuration from detection of the ublox to fully configured from 35s to 10s