Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Airspeed: Calibration: remove unused DT #29225

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

IamPete1
Copy link
Member

@IamPete1 IamPete1 commented Feb 4, 2025

No description provided.

@IamPete1
Copy link
Member Author

IamPete1 commented Feb 4, 2025

Getting some odd size results.....
Durandal saves through out, but much more than expected:

Binary Name      Text [B]         Data [B]     BSS (B)        Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  ---------------  -----------  -------------  ----------------------------  -------------------------
blimp            -20 (-0.0015%)   0 (0.0000%)  -4 (-0.0015%)  -20 (-0.0015%)                                   592224
ardurover        -120 (-0.0072%)  0 (0.0000%)  0 (0.0000%)    -120 (-0.0072%)                                  290884
ardusub          -112 (-0.0069%)  0 (0.0000%)  0 (0.0000%)    -112 (-0.0069%)                                  345704
arducopter-heli  -120 (-0.0066%)  0 (0.0000%)  0 (0.0000%)    -120 (-0.0066%)                                  136308
arduplane        -84 (-0.0046%)   0 (0.0000%)  -4 (-0.0015%)  -84 (-0.0046%)                                   150236
arducopter       -128 (-0.0070%)  0 (0.0000%)  0 (0.0000%)    -128 (-0.0070%)                                  134204
antennatracker   -40 (-0.0030%)   0 (0.0000%)  0 (0.0000%)    -40 (-0.0030%)                                   614580

MatekF405 generally costs flash:

Binary Name      Text [B]        Data [B]     BSS (B)        Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  --------------  -----------  -------------  ----------------------------  -------------------------
blimp            -4 (-0.0006%)   0 (0.0000%)  4 (+0.0031%)   -4 (-0.0006%)                                    334632
ardurover        100 (+0.0125%)  0 (0.0000%)  -4 (-0.0031%)  100 (+0.0124%)                                   179424
ardusub          92 (+0.0116%)   0 (0.0000%)  4 (+0.0031%)   92 (+0.0116%)                                    189184
arducopter-heli  -16 (-0.0018%)  0 (0.0000%)  0 (0.0000%)    -16 (-0.0018%)                                    87608
arduplane        24 (+0.0026%)   0 (0.0000%)  0 (0.0000%)    24 (+0.0026%)                                     44160
arducopter       -8 (-0.0009%)   0 (0.0000%)  0 (0.0000%)    -8 (-0.0009%)                                     92048
antennatracker   4 (+0.0006%)    0 (0.0000%)  -4 (-0.0031%)  4 (+0.0006%)                                     353416

MambaH743v4 - saves except copter/heli:

Binary Name      Text [B]         Data [B]     BSS (B)        Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  ---------------  -----------  -------------  ----------------------------  -------------------------
blimp            -36 (-0.0031%)   0 (0.0000%)  -4 (-0.0015%)  -36 (-0.0030%)                                   522016
ardurover        -148 (-0.0100%)  0 (0.0000%)  4 (+0.0015%)   -148 (-0.0100%)                                  227292
ardusub          -156 (-0.0110%)  0 (0.0000%)  -4 (-0.0015%)  -156 (-0.0110%)                                  285632
arducopter-heli  212 (+0.0130%)   0 (0.0000%)  4 (+0.0015%)   212 (+0.0130%)                                    72244
arduplane        -148 (-0.0092%)  0 (0.0000%)  -4 (-0.0015%)  -148 (-0.0092%)                                   89068
arducopter       148 (+0.0091%)   0 (0.0000%)  4 (+0.0015%)   148 (+0.0091%)                                    70188
antennatracker   -24 (-0.0021%)   0 (0.0000%)  0 (0.0000%)    -24 (-0.0021%)                                   544220

Pixhawk1-1M - costs all over

Binary Name      Text [B]        Data [B]     BSS (B)        Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  --------------  -----------  -------------  ----------------------------  -------------------------
blimp            52 (+0.0071%)   0 (0.0000%)  -4 (-0.0020%)  52 (+0.0070%)                                    293968
ardurover        100 (+0.0112%)  0 (0.0000%)  -4 (-0.0020%)  100 (+0.0112%)                                   137224
ardusub          56 (+0.0062%)   0 (0.0000%)  0 (0.0000%)    56 (+0.0062%)                                    129440
arducopter-heli  48 (+0.0049%)   0 (0.0000%)  0 (0.0000%)    48 (+0.0049%)                                     50256
arduplane        168 (+0.0164%)  0 (0.0000%)  0 (0.0000%)    168 (+0.0163%)                                     3464
arducopter       16 (+0.0016%)   0 (0.0000%)  0 (0.0000%)    16 (+0.0016%)                                     54416
antennatracker   -4 (-0.0006%)   0 (0.0000%)  -4 (-0.0020%)  -4 (-0.0006%)                                    312960

I have no idea....

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,7 +25,6 @@ Airspeed_Calibration::Airspeed_Calibration()
, Q0(0.01f)
, Q1(0.0000005f)
, state(0, 0, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This vector is implicitly zero

@peterbarker peterbarker merged commit 54a71ce into ArduPilot:master Feb 5, 2025
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants