-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken pallet_shards benchmarks #1017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
seems to give a compilation error after geenrating weights:
any idea why this import was removed from the weight.rs file? |
@penumbra23 do you know why the import was removed when the weight machine pushed the weights? |
haider-rs
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
priority: critical
ready-for-review
PR author(s) done with coding and reviewer[s] can start
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1016
shards pallet fixes
UnexpectedCommit
error iffcommit
is not expected to be called because of the member's current status not equalling MemberStatusAdded (2) returnMemberPeerIdNotFound
error iff the member has not been registered via the members pallet prior to callingcommit
frame_system::Config<AccountId = AccountId> + pallet_balances::Config<Balance = Balance>
All of these changes were required by the benchmarking fixes in this PR (listed further below).
shards pallet unit test fixes
commit
)shards pallet benchmarking fixes
commit
ready