Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken tasks::submit_hash benchmark #1015

Closed
4meta5 opened this issue Jul 19, 2024 · 2 comments · Fixed by #1024
Closed

broken tasks::submit_hash benchmark #1015

4meta5 opened this issue Jul 19, 2024 · 2 comments · Fixed by #1024
Assignees
@4meta5 @haider-rs
Labels
bug Something isn't working priority: critical

Comments

@4meta5
Copy link
Contributor

4meta5 commented Jul 19, 2024 •
edited
Loading

Benchmarking error reported by @penumbra23
@4meta5 4meta5 added the bug Something isn't working label Jul 19, 2024
@4meta5 4meta5 self-assigned this Jul 19, 2024
@4meta5 4meta5 mentioned this issue Jul 20, 2024
Closed
3 tasks
@4meta5
Copy link
Contributor Author

4meta5 commented Jul 23, 2024

#1017 was sufficient to close this issue. #1014 introduced what was expected as a fix but the fix introduced a bug which failed the existing benchmark unit test bench_submit_hash. I don't really understand why, but this issue seems to be closed AFAIU

@4meta5 4meta5 closed this as completed Jul 23, 2024
@4meta5
Copy link
Contributor Author

4meta5 commented Jul 24, 2024

Not closed, @Haider-Ali-DS showed that the bug still exists via CI in #1023

@4meta5 4meta5 reopened this Jul 24, 2024
@4meta5 4meta5 mentioned this issue Jul 24, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4meta5 4meta5

@haider-rs haider-rs

Labels
bug Something isn't working priority: critical
Projects
None yet
Milestone
No milestone
2 participants
@4meta5 @haider-rs