-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rpm mode #108
base: master
Are you sure you want to change the base?
Rpm mode #108
Conversation
add HGLRC35 target
I like parts of this, the drive by rpm mode was going to be an eeprom addition in the future and i have added those changes to my config too but I used different memory offsets. I would not be able to merge this as is. Do you use discord? I would like to discuss this more with you possibly. There are many things that i would like to incorporate from your pr but there are a few things to consider when increasing the settings area. |
OK that's nice if you can include the rpm mode tuning in the esc configuration tools. |
Hi,
I have worked on rpm mode with the AM32 firmware. It would be nice if you integrate the changes on your code.
The main modifications are :
Improvement of the closed loop rpm mode
Change the eeprom memory layout to add rpm mode activation and pid tuning
eeprom[48] : RPM mode if val !=0
eeprom[49] : min RPM / 1000
eeprom[50] : max RPM / 1000
eeprom[51] : PID.Kp
eeprom[52] : PID.Ki
eeprom[53] : PID.Kd
eeprom[54] : PID.integral_limit / 100000
Add an option to configure the serial telemetry pin in OpenDrain
Add some targets (HGLRC35_F051 for hglrc T-Rex 35A, and HKMICRO_F051 for ReadyToSky 35A LED)
I have successfully tested the firmware with HGLRC esc T-Rex 35A, HGLRC 4en1 Zeus 45A and ReadyToSky 35A)