Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: enable logos for SK and CZ online banking #2939

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Feat: enable logos for SK and CZ online banking #2939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc308dd
feat: enable logos for SK and CZ online banking
m1aw Nov 7, 2024
210ba8e
changeset
m1aw Nov 7, 2024
4770366
update SK currency to EUR on playgrounds
m1aw Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-boats-applaud.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@adyen/adyen-web': minor
---

Feat: enable logos for SK and CZ online banking
1 change: 0 additions & 1 deletion examples/angular/src/utils/getCurrency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const currencies: Record<string, string> = {
RU: 'RUB',
SE: 'SEK',
SG: 'SGD',
SK: 'SKK',
TH: 'THB',
TW: 'TWD',
US: 'USD',
Expand Down
1 change: 0 additions & 1 deletion examples/nextjs/app/_utils/amount-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const currencies = {
RU: "RUB",
SE: "SEK",
SG: "SGD",
SK: "SKK",
TH: "THB",
TW: "TWD",
US: "USD",
Expand Down
1 change: 0 additions & 1 deletion examples/nextjs/app/_utils/getCurrency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const currencies = {
RU: "RUB",
SE: "SEK",
SG: "SGD",
SK: "SKK",
TH: "THB",
TW: "TWD",
US: "USD",
Expand Down
1 change: 0 additions & 1 deletion examples/nuxt/utils/getCurrency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const currencies: Record<string, string> = {
RU: 'RUB',
SE: 'SEK',
SG: 'SGD',
SK: 'SKK',
TH: 'THB',
TW: 'TWD',
US: 'USD',
Expand Down
2 changes: 1 addition & 1 deletion packages/lib/src/components/OnlineBankingCZ/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class OnlineBankingCZElement extends IssuerListContainer {
formatProps(props) {
return {
...super.formatProps(props),
showImage: false,
showImage: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it can be omitted since its default is true. Same for OnlineBankingSK

termsAndConditions: OnlineBankingCZElement.termsAndConditions
};
}
Expand Down
2 changes: 1 addition & 1 deletion packages/lib/src/components/OnlineBankingSK/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class OnlineBankingSKElement extends IssuerListContainer {
formatProps(props) {
return {
...super.formatProps(props),
showImage: false,
showImage: true,
termsAndConditions: OnlineBankingSKElement.termsAndConditions
};
}
Expand Down
24 changes: 24 additions & 0 deletions packages/lib/storybook/stories/issuer-lists/OnlineBankingCZ.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { MetaConfiguration, StoryConfiguration } from '../types';
import { ComponentContainer } from '../ComponentContainer';
import { IssuerListConfiguration } from '../../../src/components/helpers/IssuerListContainer/types';
import { Checkout } from '../Checkout';
import { OnlineBankingCZ } from '../../../src';

type OnlineBankingCZStory = StoryConfiguration<IssuerListConfiguration>;

const meta: MetaConfiguration<IssuerListConfiguration> = {
title: 'IssuerList/OnlineBankingCZ'
};

export const Default: OnlineBankingCZStory = {
render: ({ componentConfiguration, ...checkoutConfig }) => (
<Checkout checkoutConfig={checkoutConfig}>
{checkout => <ComponentContainer element={new OnlineBankingCZ(checkout, componentConfiguration)} />}
</Checkout>
),
args: {
countryCode: 'CZ'
}
};

export default meta;
24 changes: 24 additions & 0 deletions packages/lib/storybook/stories/issuer-lists/OnlineBankingSK.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { MetaConfiguration, StoryConfiguration } from '../types';
import { ComponentContainer } from '../ComponentContainer';
import { IssuerListConfiguration } from '../../../src/components/helpers/IssuerListContainer/types';
import { Checkout } from '../Checkout';
import { OnlineBankingSK } from '../../../src';

type OnlineBankingSKStory = StoryConfiguration<IssuerListConfiguration>;

const meta: MetaConfiguration<IssuerListConfiguration> = {
title: 'IssuerList/OnlineBankingSK'
};

export const Default: OnlineBankingSKStory = {
render: ({ componentConfiguration, ...checkoutConfig }) => (
<Checkout checkoutConfig={checkoutConfig}>
{checkout => <ComponentContainer element={new OnlineBankingSK(checkout, componentConfiguration)} />}
</Checkout>
),
args: {
countryCode: 'SK'
}
};

export default meta;
1 change: 0 additions & 1 deletion packages/lib/storybook/utils/get-currency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const currencies: Record<string, string> = {
RU: 'RUB',
SE: 'SEK',
SG: 'SGD',
SK: 'SKK',
TH: 'THB',
TW: 'TWD',
US: 'USD',
Expand Down
1 change: 0 additions & 1 deletion packages/playground/src/config/getCurrency.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const currencies = {
RU: 'RUB',
SE: 'SEK',
SG: 'SGD',
SK: 'SKK',
TH: 'THB',
TW: 'TWD',
US: 'USD',
Expand Down
Loading