Feat: enable logos for SK and CZ online banking #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1aw
requested review from
marcperez,
pabloai,
sponglord,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 4770366 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -7 B (0%) Total Size: 768 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
|
ribeiroguilherme
approved these changes
Dec 4, 2024
| @@ -15,7 +15,7 @@ class OnlineBankingCZElement extends IssuerListContainer { | |||
| formatProps(props) { | |||
| return { | |||
| ...super.formatProps(props), | |||
| showImage: false, | |||
| showImage: true, | |||
There was a problem hiding this comment.
I guess it can be omitted since its default is true. Same for OnlineBankingSK
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set
showImage: truefor both CZ and SK online banking. Images should be already available.Also remove
SKKsupport from the playground in favour ofEUR.Tested scenarios
CZ component.
SK component tested, but missing the full response in Test env, should be correct in Live according to LPM.
Fixed issue: