[rqd] Change default RQD_BECOME_JOB_USER from True to False #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithorus
requested review from
bcipriano,
DiegoTavares and
ramonfigueiredo
as code owners
|
I'm okay with changing the default to false, as long as there's an option on rqd.conf to set it to true. If there isn't one, please add and document on the rqd.example.conf file what scenarios it would make sense to have it as true |
I'll copy the example and description from the rqd/READMDE.md file. |
DiegoTavares
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Change default RQD_BECOME_JOB_USER from True to False
Reason for change
I think most studios don't expect the render client to change to the user of the render submitter, but have a "render" user dedicated for it. Also, it's not very obvious why root is required to run RQD and that the behavior can be turned off.