Skip to content

Commit

Permalink
[rqd] Change default RQD_BECOME_JOB_USER from True to False (#1659)
Browse files Browse the repository at this point in the history
**Summarize your change.**
Change default RQD_BECOME_JOB_USER from True to False

**Reason for change**
I think most studios don't expect the render client to change to the
user of the render submitter, but have a "render" user dedicated for it.
Also, it's not very obvious why root is required to run RQD and that the
behavior can be turned off.
  • Loading branch information
lithorus authored Feb 12, 2025
1 parent aba67ce commit e2d1f12
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
6 changes: 3 additions & 3 deletions rqd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ python3 setup.py install
### Create rqd.conf
Example `rqd.conf` file :

```toml
```ini
[Override]
## Variable that decided if RQD should switch to the user of the job running. Requires root
RQD_BECOME_JOB_USER = False
# Variable that decided if RQD should switch to the user of the job running. Requires root
RQD_BECOME_JOB_USER = False

# Log levels for RQD
CONSOLE_LOG_LEVEL = INFO
Expand Down
2 changes: 2 additions & 0 deletions rqd/rqd.example.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
# If this file is not found the defaults in rqconstants.py will be used.

[Override]
# Variable that decided if RQD should switch to the user of the job running. Requires root
RQD_BECOME_JOB_USER = False
RQD_USE_PATH_ENV_VAR=1
RQD_USE_IP_AS_HOSTNAME=0
OVERRIDE_IS_DESKTOP=True
Expand Down
2 changes: 1 addition & 1 deletion rqd/rqd/rqconstants.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
RQD_CUSTOM_HOME_PREFIX = None
RQD_CUSTOM_MAIL_PREFIX = None

RQD_BECOME_JOB_USER = True
RQD_BECOME_JOB_USER = False
RQD_CREATE_USER_IF_NOT_EXISTS = True
SENTRY_DSN_PATH = None
RQD_TAGS = ''
Expand Down
5 changes: 1 addition & 4 deletions rqd/tests/rqcore_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -763,10 +763,7 @@ def test_runLinux(
"-p",
"-o",
jobTempPath + "rqd-stat-" + frameId + "-" + str(currentTime),
"/bin/su",
frameUsername,
"-c",
'"' + tempDir + "/rqd-cmd-" + frameId + "-" + str(currentTime) + '"',
tempDir + "/rqd-cmd-" + frameId + "-" + str(currentTime),
],
env=mock.ANY,
cwd=jobTempPath,
Expand Down

0 comments on commit e2d1f12

Please sign in to comment.