Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo url file #150

Merged
merged 56 commits into from
Dec 14, 2023
Merged

Redo url file #150

merged 56 commits into from
Dec 14, 2023

Conversation

jacquelynsmale
Copy link
Contributor

No description provided.

@jacquelynsmale jacquelynsmale requested a review from a team November 14, 2023 19:23
@jacquelynsmale jacquelynsmale marked this pull request as draft November 14, 2023 19:23
OPERA Level-2 Radiometric Terrain Corrected (RTC) products in HH polarization generated from Sentinel-1 SAR imagery, processed by OPERA (JPL). Values for the HH polarization are commonly driven by surface roughness and/or soil moisture, with rougher surfaces and higher soil moisture returning higher backscatter values. Surface water appears very dark under calm conditions, as the signal bounces off the surface away from the sensor.

Credits:
OPERA Level-2 Radiometric Terrain Corrected Static Layers from Sentinel-1. Contains modified Copernicus Sentinel data, processed by ESA.
Copy link
Contributor

@hjkristenson hjkristenson Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPERA Level-2 Radiometric Terrain Corrected Static Layers from Sentinel-1. Contains modified Copernicus Sentinel data, processed by ESA.
OPERA Level-2 Radiometric Terrain Corrected SAR Backscatter from Sentinel-1. NASA Alaska Satellite Facility Distributed Active Archive Center. doi: https://doi.org/10.5067/SNWG/OPERA_L2_RTC-S1_V1. Contains modified Copernicus Sentinel data, processed by ESA.

OPERA Level-2 Radiometric Terrain Corrected (RTC) products in HV polarization generated from Sentinel-1 SAR imagery, processed by OPERA (JPL). Values for the HV polarization are commonly driven by surface roughness and/or soil moisture, with rougher surfaces and higher soil moisture returning higher backscatter values. Surface water appears very dark under calm conditions, as the signal bounces off the surface away from the sensor.

Credits:
OPERA Level-2 Radiometric Terrain Corrected Static Layers from Sentinel-1. Contains modified Copernicus Sentinel data, processed by ESA.
Copy link
Contributor

@hjkristenson hjkristenson Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPERA Level-2 Radiometric Terrain Corrected Static Layers from Sentinel-1. Contains modified Copernicus Sentinel data, processed by ESA.
OPERA Level-2 Radiometric Terrain Corrected SAR Backscatter from Sentinel-1. NASA Alaska Satellite Facility Distributed Active Archive Center. doi: https://doi.org/10.5067/SNWG/OPERA_L2_RTC-S1_V1. Contains modified Copernicus Sentinel data, processed by ESA.

OPERA Level-2 Radiometric Terrain Corrected (RTC) products in VV polarization generated from Sentinel-1 SAR imagery, processed by OPERA (JPL). Values for the VV polarization are commonly driven by surface roughness and/or soil moisture, with rougher surfaces and higher soil moisture returning higher backscatter values. Surface water appears very dark under calm conditions, as the signal bounces off the surface away from the sensor.

Credits:
OPERA Level-2 Radiometric Terrain Corrected Static Layers from Sentinel-1. Contains modified Copernicus Sentinel data, processed by ESA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPERA Level-2 Radiometric Terrain Corrected Static Layers from Sentinel-1. Contains modified Copernicus Sentinel data, processed by ESA.
OPERA Level-2 Radiometric Terrain Corrected SAR Backscatter from Sentinel-1. NASA Alaska Satellite Facility Distributed Active Archive Center. doi: https://doi.org/10.5067/SNWG/OPERA_L2_RTC-S1_V1. Contains modified Copernicus Sentinel data, processed by ESA.

OPERA Level-2 Radiometric Terrain Corrected (RTC) products in {{ polarization }} polarization generated from Sentinel-1 SAR imagery, processed by OPERA (JPL). Values for the {{ polarization }} polarization are commonly driven by surface roughness and/or soil moisture, with rougher surfaces and higher soil moisture returning higher backscatter values. Surface water appears very dark under calm conditions, as the signal bounces off the surface away from the sensor.

Credits:
OPERA Level-2 Radiometric Terrain Corrected Static Layers from Sentinel-1. Contains modified Copernicus Sentinel data, processed by ESA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPERA Level-2 Radiometric Terrain Corrected Static Layers from Sentinel-1. Contains modified Copernicus Sentinel data, processed by ESA.
OPERA Level-2 Radiometric Terrain Corrected SAR Backscatter from Sentinel-1. NASA Alaska Satellite Facility Distributed Active Archive Center. doi: https://doi.org/10.5067/SNWG/OPERA_L2_RTC-S1_V1. Contains modified Copernicus Sentinel data, processed by ESA.

@jacquelynsmale jacquelynsmale changed the base branch from develop to opera-egis-updates December 14, 2023 00:30
@jacquelynsmale jacquelynsmale marked this pull request as ready for review December 14, 2023 00:35
Copy link
Contributor

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! A couple of exceedingly minor suggestions you can take or leave, and a couple of questions for parts I wasn't sure about that look deliberate -- just curious why; not blocking.

Comment on lines 24 to 25
with open(filename, newline='') as urlfile:
records = urlfile.read().split('\n')[:-1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting -- is this a windows thing? I would have expected:

with open(filename) as urlfile:
    records = urlfile.read().splitlines()[:-1]

or with pathlib:

Path(filename).read_text().splitlines()[:-1]

image_services/opera/update_opera_urls.py Outdated Show resolved Hide resolved
image_services/opera/update_opera_urls.sh Outdated Show resolved Hide resolved
filename = f'{dataset_name}_vsis3_urls.csv'
with open(filename, newline='') as urlfile:
records = urlfile.read().split('\n')[:-1]
return [f'{record[:-1]}' for record in records]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What character are you stripping here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhkennedy an empty space :/ Kinda hacky. I don't know why it keeps putting it there?

Copy link
Contributor

@jhkennedy jhkennedy Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacquelynsmale is it a space or a carriage return? If there's a space in the file that's why it'd be there, but windows does line endings with a \r\n (carriage return and new line). The with block has newline='' which does not translate \r\n into a single \n character, so your split would mean there's potentially a trailing \r if the csv was written on a windows box

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacquelynsmale if you're stripping whitespace from the end of the line, you could also just do:

    return [record.rstrip() for record in records]

Or from both ends with strip()

@jacquelynsmale jacquelynsmale merged commit d0b5bd8 into opera-egis-updates Dec 14, 2023
1 of 2 checks passed
@jacquelynsmale jacquelynsmale deleted the redo-url-file branch December 14, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants