-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint #5334
Update eslint #5334
Conversation
This will enforce CI ESLint. I would like to backport to 3.8 to easy backports if possible. |
Maybe we can merge on master and 3.9 and wait for the point release on 3.8 before merging on this branch. I'm not 100% sure about this PR for now. |
Unrelated test failure |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_8 release_3_8
# Navigate to the new working tree
cd .worktrees/backport-release_3_8
# Create a new branch
git switch --create backport-5334-to-release_3_8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 91c4196980ccbcaec4def5c80256f4604b1e1556,0e12ee2750171a62d8bfb28b718a9213109f3878,2568f1fcccbf63b65711e0a0b0c75d1aa173b77f,86fff847fb4cdf0eb39d7485e8d95687ded9ffd8,adf4a117cd483c2fd731218e118840b18a099b6a,edb5c96052d17e23e5383348eacd806f1ef3009a
# Push it to GitHub
git push --set-upstream origin backport-5334-to-release_3_8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_8 Then, create a pull request where the |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_9 release_3_9
# Navigate to the new working tree
cd .worktrees/backport-release_3_9
# Create a new branch
git switch --create backport-5334-to-release_3_9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 91c4196980ccbcaec4def5c80256f4604b1e1556,0e12ee2750171a62d8bfb28b718a9213109f3878,2568f1fcccbf63b65711e0a0b0c75d1aa173b77f,86fff847fb4cdf0eb39d7485e8d95687ded9ffd8,adf4a117cd483c2fd731218e118840b18a099b6a,edb5c96052d17e23e5383348eacd806f1ef3009a
# Push it to GitHub
git push --set-upstream origin backport-5334-to-release_3_9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_9 Then, create a pull request where the |
Rebased work from @neo-garaix about #5294