Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ESLint #5294

Closed
wants to merge 5 commits into from
Closed

Improve ESLint #5294

wants to merge 5 commits into from

Conversation

neo-garaix
Copy link
Contributor

@neo-garaix neo-garaix commented Jan 29, 2025 •
edited
Loading

Improvement of ESLint

  • Improved ESLint configuration to new standards
  • All assets files except legacy are scanned
  • Added ESLint to the lint.yml workflow
  • Applied ESLint and fixed issues

To be rebased on #5303

Funded by 3Liz

@github-actions github-actions bot added this to the 3.10.0 milestone Jan 29, 2025
Gustry
Gustry reviewed Jan 29, 2025
View reviewed changes
assets/eslint.config.mjs Outdated Show resolved Hide resolved
@Gustry Gustry added the javascript Pull requests that update Javascript code label Jan 29, 2025
@Gustry
Copy link
Member

Gustry commented Jan 29, 2025

It would be great if this can be added to .pre-commit-config.yaml if it's not too long (and other commands as well)

Note for myself later, have a look to depandabot

This was referenced Jan 31, 2025
Closed
Merged
@Gustry
Copy link
Member

Gustry commented Feb 3, 2025

Done in #5334

@Gustry Gustry closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustry Gustry Gustry left review comments

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neo-garaix @Gustry