[#92] Chore: router type 선언 및 devtools 추가 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kim-Jaemin420
requested review from
choi-ik,
yjc2021,
hyeonjinan096 and
HY219
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
choi-ik
approved these changes
Mar 4, 2024
HY219
approved these changes
Mar 4, 2024
yjc2021
reviewed
Mar 4, 2024
src/App.tsx
Outdated
| @@ -1,13 +1,20 @@ | |||
| import { RouterProvider, createRouter } from "@tanstack/react-router"; | |||
| import { OverlayProvider } from "@toss/use-overlay"; | |||
| import { QueryClient, QueryClientProvider } from "@tanstack/react-query"; | |||
|
|
|||
There was a problem hiding this comment.
import 사이에 개행 추가하신 이유가 있는지 궁금합니다 :)
There was a problem hiding this comment.
devtools 추가/삭제하다 보니 실수했네요! 감사합니다ㅎㅎ
|
@HY219 님! 저도 생각해보니 imageId가 애초에 number 타입으로 지정하면 좋지 않을까 해서 찾아보니, url params는 기본적으로 문자열로 처리되어 어쩔 수 없이 string 타입으로 지정해야 하는 것 같습니다ㅠ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
Link, navigate의 path 타입을 추론할 수 있도록 router type 선언해주었습니다. Link 작성시 아래처럼 자동완성이 됩니다.
react query devtools와 tanstack router devtools를 설치하고 적용했습니다.
+) Link 타입을 적용하면서 타입이 맞지 않는 것들을 타입에 맞도록 수정해주었습니다.
close #92