[#56] Feat: 좋아요한 짤 api 및 커스텀 훅 구현 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
choi-ik
reviewed
Feb 22, 2024
src/routes/my-liked-zzal/index.tsx
Outdated
Comment on lines
22
to
24
| <div className="mb-4 inline-block break-inside-avoid"> | ||
| <ZzalCard src={path} alt="" /> | ||
| </div> |
| import { GetMyLikedZzalsResponse } from "@/types/zzal.dto"; | ||
| import http from "./core"; | ||
|
|
||
| const SIZE = 10; |
There was a problem hiding this comment.
이 부분 따로 Constants 폴더에서 관리하지 않아도 될까요??
There was a problem hiding this comment.
이거 아직 확정이 아니라서 우선 여기에 뒀는데 확정되면 옮기려구요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
좋아요한 짤 api와 커스텀 훅 구현
useSuspenseInfiniteQuery를 사용하여 커스텀 훅 구현뷰포트 크기에 맞게 열 개수를 조절
ZzalCard 수정
이미지 크기 이상의 높이를 가져서
h-fit추가pending 컴포넌트 선언
suspense 사용으로 인해 pending 컴포넌트가 필요해 우선 선언만 해두었습니다.
close #56