-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#114] Feat: 계정 삭제 페이지 layout 구현 #120
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
#114/feature/account-delete-page-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!🚀
src/routes/delete-account/index.tsx
Outdated
<h1 className={cn({ "text-primary": currentStep === "DeletionConfirm" })}>1. 확인</h1> | ||
</li> | ||
<li> | ||
<h1 className={cn({ "text-primary": currentStep === "DeletionCompleted" })}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step에서 DeletionConfirm , DeleteConfirm, DeletionCompleted, DeleteComplete가 혼용되고 있는 것 같습니다! Deletion 또는 Delete 하나로 통일해야 할 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 죄송합니다 Delete로 통일하겠습니다ㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦖
📝 작업 내용
✅useFunnel 훅 구현
useFunnel 초기값은
const { Funnel, Step, setStep, currentStep } = useFunnel([ 'step1','step2'] as const);
이렇게 배열과 as const로 지정합니다.
이런 형태로 컴포넌트 간 이동을 위해 훅을 사용할 수 있습니다.
📷 스크린샷 (선택)
💬 리뷰 요구사항(선택)
close #114