Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#114] Feat: 계정 삭제 페이지 layout 구현 #120

Merged
merged 12 commits into from
Mar 11, 2024

Conversation

hyeonjinan096
Copy link
Contributor

@hyeonjinan096 hyeonjinan096 commented Mar 9, 2024

📝 작업 내용

계정 삭제 페이지 layout 구현했습니다.

✅useFunnel 훅 구현

useFunnel 초기값은
const { Funnel, Step, setStep, currentStep } = useFunnel([ 'step1','step2'] as const);
이렇게 배열과 as const로 지정합니다.

<Funnel>
  <Step name="step1">
    <DeleteConfirm onNext={()=>setStep("step2")} />
  </Step>
  <Step name="step2">
    <DeleteCompleted />
  </Step>
</Funnel>

이런 형태로 컴포넌트 간 이동을 위해 훅을 사용할 수 있습니다.

📷 스크린샷 (선택)

💬 리뷰 요구사항(선택)

className 중복되는게 많아서 컴포넌트화를 고민하다가 중복되는 className을 변수화했는데 적절할까요?
코드 구조가 적절한지 고민이 되네요😅

close #114

@hyeonjinan096 hyeonjinan096 added the ✨ Feature 새로운 기능 추가 label Mar 9, 2024
@hyeonjinan096 hyeonjinan096 self-assigned this Mar 9, 2024
Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zzalmyu-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 2:24am

src/routes/delete-account/index.tsx Outdated Show resolved Hide resolved
src/routes/delete-account/index.tsx Show resolved Hide resolved
Copy link
Contributor

@choi-ik choi-ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀

<h1 className={cn({ "text-primary": currentStep === "DeletionConfirm" })}>1. 확인</h1>
</li>
<li>
<h1 className={cn({ "text-primary": currentStep === "DeletionCompleted" })}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step에서 DeletionConfirm , DeleteConfirm, DeletionCompleted, DeleteComplete가 혼용되고 있는 것 같습니다! Deletion 또는 Delete 하나로 통일해야 할 것 같아요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 죄송합니다 Delete로 통일하겠습니다ㅠ

Copy link
Contributor

@yjc2021 yjc2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@hyeonjinan096 hyeonjinan096 merged commit 9e70d0a into main Mar 11, 2024
3 checks passed
@hyeonjinan096 hyeonjinan096 deleted the #114/feature/account-delete-page-ui branch March 11, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

계정 삭제 페이지 UI 구현
3 participants