Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#105] Refactor: ImageDetailModal과 ImageMenuBar 병합 #106

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[#105] Refactor: ImageDetailModal과 ImageMenuBar 병합 #106

merged 1 commit into from
Mar 7, 2024

Conversation

HY219
Copy link
Contributor

@HY219 HY219 commented Mar 6, 2024 •
edited
Loading

📝 작업 내용

  • ImageDetailModal과 ImageMenuBar 병합에 따른 리펙토링
    • ImageMenuBar.tsx의 코드를 .src/components/ImageDetailModal/index.tsx에 병합
  • 신고, 제거 핸들러 함수 이름 변경
  • imageDetails에 있는 imageId 사용

📷 스크린샷 (선택)

💬 리뷰 요구사항(선택)

  • 확인 및 리뷰 부탁드려요:)

📍 기타 (선택)

  • 이전에 approve 해주신 신고 확인 모달 ui와 신고 api, 삭제 api 코드 모두 변경사항 없이 병합만 해주었습니다!
  • 코드는 변경된 사항 없습니다:)

close #105

@HY219
Refactor: ImageDetailModal과 ImageMenuBar 병합
9716fc3 
신고, 제거 핸들러 함수 이름 변경
imageDetails에 있는 imageId 사용
@HY219 HY219 self-assigned this Mar 6, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zzalmyu-frontend ✅ Ready (Inspect) Visit Preview Mar 6, 2024 5:56am

@HY219 HY219 added 🔨 Refactor (코드의 동작은 일치)코드 리팩토링 🏷️ Rename 디렉토리 구조 변경, 함수 이름 변경 labels Mar 6, 2024
yjc2021
yjc2021 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@yjc2021 yjc2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Kim-Jaemin420
Kim-Jaemin420 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@Kim-Jaemin420 Kim-Jaemin420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@HY219 HY219 merged commit 5a96042 into main Mar 7, 2024
3 checks passed
@HY219 HY219 deleted the #105/refactor/image-modal-menu-merge branch March 7, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjc2021 yjc2021 yjc2021 approved these changes

@Kim-Jaemin420 Kim-Jaemin420 Kim-Jaemin420 approved these changes

@choi-ik choi-ik Awaiting requested review from choi-ik choi-ik is a code owner

@hyeonjinan096 hyeonjinan096 Awaiting requested review from hyeonjinan096 hyeonjinan096 is a code owner

Assignees

@HY219 HY219

Labels
🔨 Refactor (코드의 동작은 일치)코드 리팩토링 🏷️ Rename 디렉토리 구조 변경, 함수 이름 변경
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageDetailModal과 ImageMenuBar 병합에 따른 리팩토링
3 participants
@HY219 @Kim-Jaemin420 @yjc2021