Aspect fill the image on double tap #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximumZoomScale still respected and allows zooming beyond aspect fill
…trols Technically, this would be a breaking change as current implementations don't expect ImageSlideshow to listen for `.valueChanged` on a PageControl they set themselves. That said, this would be a nice addition so that users of ImageSlideshow don't have to implement this logic themselves.
* Update gitignore for Swift Package Manager * Bundle resources * Load resources in the module
# Conflicts: # Example/Podfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double tap now zooms to fill the ImageSlideshow view (screen).
maximumZoomScaleis still respected and can be set to a much higher scale to allow closely zooming images beyond what double tap would zoom.Omitted commit from #300 for when zoom behavior is refactored.